Suppress compiler warning.

tglsfdc · tglsfdc · commit 45aae8e78967 · 2016-04-02T13:49:17.000-04:00
Some buildfarm members are showing "comparison is always false due to
limited range of data type" complaints on this test, so #ifdef it out
on machines with 32-bit int.
diff --git a/src/timezone/zic.c b/src/timezone/zic.c
@@ -1179,11 +1179,14 @@ gethms(char const * string, char const * errstring, bool signable)
 		error("%s", errstring);
 		return 0;
 	}
-	if (ZIC_MAX / SECSPERHOUR < (zic_t) hh)
+	/* Some compilers warn that this test is unsatisfiable for 32-bit ints */
+#if INT_MAX > PG_INT32_MAX
+	if (ZIC_MAX / SECSPERHOUR < hh)
 	{
 		error(_("time overflow"));
 		return 0;
 	}
+#endif
 	if (noise && (hh > HOURSPERDAY ||
 				  (hh == HOURSPERDAY && (mm != 0 || ss != 0))))
 		warning(_("values over 24 hours not handled by pre-2007 versions of zic"));

Original file line number	Diff line number	Diff line change
`@@ -1179,11 +1179,14 @@ gethms(char const * string, char const * errstring, bool signable)`
`1179`	`1179`	`error("%s", errstring);`
`1180`	`1180`	`return 0;`
`1181`	`1181`	`}`
`1182`		`- if (ZIC_MAX / SECSPERHOUR < (zic_t) hh)`
	`1182`	`+ /* Some compilers warn that this test is unsatisfiable for 32-bit ints */`
	`1183`	`+#if INT_MAX > PG_INT32_MAX`
	`1184`	`+ if (ZIC_MAX / SECSPERHOUR < hh)`
`1183`	`1185`	`{`
`1184`	`1186`	`error(_("time overflow"));`
`1185`	`1187`	`return 0;`
`1186`	`1188`	`}`
	`1189`	`+#endif`
`1187`	`1190`	`if (noise && (hh > HOURSPERDAY \|\|`
`1188`	`1191`	`(hh == HOURSPERDAY && (mm != 0 \|\| ss != 0))))`
`1189`	`1192`	`warning(_("values over 24 hours not handled by pre-2007 versions of zic"));`