Fix resource leak pointed out by Coverity.

tatsuo-ishii · tatsuo-ishii · commit 4c136b0b6389 · 2014-12-30T19:48:53.000+09:00
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -1386,6 +1386,7 @@ parseQuery(Command *cmd, const char *raw_sql)
 		if (cmd->argc >= MAX_ARGS)
 		{
 			fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);
+			free(name);
 			return false;
 		}
 
@@ -1582,6 +1583,7 @@ process_file(char *filename)
 		fd = stdin;
 	else if ((fd = fopen(filename, "r")) == NULL)
 	{
+		free(my_commands);
 		fprintf(stderr, "%s: %s\n", filename, strerror(errno));
 		return false;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1386,6 +1386,7 @@ parseQuery(Command cmd, const char raw_sql)`
`1386`	`1386`	`if (cmd->argc >= MAX_ARGS)`
`1387`	`1387`	`{`
`1388`	`1388`	`fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);`
	`1389`	`+ free(name);`
`1389`	`1390`	`return false;`
`1390`	`1391`	`}`
`1391`	`1392`
`@@ -1582,6 +1583,7 @@ process_file(char *filename)`
`1582`	`1583`	`fd = stdin;`
`1583`	`1584`	`else if ((fd = fopen(filename, "r")) == NULL)`
`1584`	`1585`	`{`
	`1586`	`+ free(my_commands);`
`1585`	`1587`	`fprintf(stderr, "%s: %s\n", filename, strerror(errno));`
`1586`	`1588`	`return false;`
`1587`	`1589`	`}`