Fix check for empty hostname.

hlinnaka · hlinnaka · commit 4d06f1f858d0 · 2017-07-10T15:29:36.000+03:00
As reported by Arthur Zakirov, Gcc 7.1 complained about this with -Wpointer-compare. Discussion: https://www.postgresql.org/message-id/CAKNkYnybV_NFVacGbW=VspzAo3TwRJFNi+9iBob66YqQMZopwg@mail.gmail.com
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -965,8 +965,8 @@ connectOptions2(PGconn *conn)
 		{
 			conn->status = CONNECTION_BAD;
 			printfPQExpBuffer(&conn->errorMessage,
-			libpq_gettext("could not match %d host names to %d hostaddrs\n"),
-				 count_comma_separated_elems(conn->pghost), conn->nconnhost);
+							  libpq_gettext("could not match %d host names to %d hostaddrs\n"),
+							  count_comma_separated_elems(conn->pghost), conn->nconnhost);
 			return false;
 		}
 	}
@@ -1097,7 +1097,7 @@ connectOptions2(PGconn *conn)
 			char	   *pwhost = conn->connhost[i].host;
 
 			if (conn->connhost[i].type == CHT_HOST_ADDRESS &&
-			conn->connhost[i].host != NULL && conn->connhost[i].host != '\0')
+				conn->connhost[i].host != NULL && conn->connhost[i].host[0] != '\0')
 				pwhost = conn->connhost[i].hostaddr;
 
 			conn->connhost[i].password =

Original file line number	Diff line number	Diff line change
`@@ -965,8 +965,8 @@ connectOptions2(PGconn *conn)`
`965`	`965`	`{`
`966`	`966`	`conn->status = CONNECTION_BAD;`
`967`	`967`	`printfPQExpBuffer(&conn->errorMessage,`
`968`		`- libpq_gettext("could not match %d host names to %d hostaddrs\n"),`
`969`		`- count_comma_separated_elems(conn->pghost), conn->nconnhost);`
	`968`	`+ libpq_gettext("could not match %d host names to %d hostaddrs\n"),`
	`969`	`+ count_comma_separated_elems(conn->pghost), conn->nconnhost);`
`970`	`970`	`return false;`
`971`	`971`	`}`
`972`	`972`	`}`
`@@ -1097,7 +1097,7 @@ connectOptions2(PGconn *conn)`
`1097`	`1097`	`char *pwhost = conn->connhost[i].host;`
`1098`	`1098`
`1099`	`1099`	`if (conn->connhost[i].type == CHT_HOST_ADDRESS &&`
`1100`		`- conn->connhost[i].host != NULL && conn->connhost[i].host != '\0')`
	`1100`	`+ conn->connhost[i].host != NULL && conn->connhost[i].host[0] != '\0')`
`1101`	`1101`	`pwhost = conn->connhost[i].hostaddr;`
`1102`	`1102`
`1103`	`1103`	`conn->connhost[i].password =`