release memory used while flushing logical mappings

bmomjian · bmomjian · commit 4d0d607a454e · 2014-04-22T18:05:44.000-04:00
Patch by Ants Aasma
diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c
@@ -897,7 +897,7 @@ logical_heap_rewrite_flush_mappings(RewriteState state)
 
 		/* write all mappings consecutively */
 		len = src->num_mappings * sizeof(LogicalRewriteMappingData);
-		waldata = palloc(len);
+		waldata = MemoryContextAlloc(state->rs_cxt, len);
 		waldata_start = waldata;
 
 		/*
@@ -943,6 +943,7 @@ logical_heap_rewrite_flush_mappings(RewriteState state)
 		/* write xlog record */
 		XLogInsert(RM_HEAP2_ID, XLOG_HEAP2_REWRITE, rdata);
 
+		pfree(waldata);
 	}
 	Assert(state->rs_num_rewrite_mappings == 0);
 }

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,7 @@ logical_heap_rewrite_flush_mappings(RewriteState state)`
`897`	`897`
`898`	`898`	`/* write all mappings consecutively */`
`899`	`899`	`len = src->num_mappings * sizeof(LogicalRewriteMappingData);`
`900`		`- waldata = palloc(len);`
	`900`	`+ waldata = MemoryContextAlloc(state->rs_cxt, len);`
`901`	`901`	`waldata_start = waldata;`
`902`	`902`
`903`	`903`	`/*`
`@@ -943,6 +943,7 @@ logical_heap_rewrite_flush_mappings(RewriteState state)`
`943`	`943`	`/* write xlog record */`
`944`	`944`	`XLogInsert(RM_HEAP2_ID, XLOG_HEAP2_REWRITE, rdata);`
`945`	`945`
	`946`	`+ pfree(waldata);`
`946`	`947`	`}`
`947`	`948`	`Assert(state->rs_num_rewrite_mappings == 0);`
`948`	`949`	`}`