Fixed a few trivial memory leaks reported by Coverity just to test my setup.

Michael Meskes · Michael Meskes · commit 4e23d6e07ddb · 2006-08-20T16:08:09.000Z
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -42,7 +42,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  * Portions taken from FreeBSD.
  *
- * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.120 2006/07/31 01:16:37 tgl Exp $
+ * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.121 2006/08/20 16:08:09 meskes Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -419,6 +419,7 @@ readfile(char *path)
 	}
 
 	fclose(infile);
+	free(buffer);
 	result[nlines] = NULL;
 
 	return result;
@@ -1058,6 +1059,7 @@ set_short_version(char *short_version, char *extrapath)
 				progname, path, strerror(errno));
 		exit_nicely();
 	}
+	free(path);
 }
 
 /*
@@ -1085,6 +1087,7 @@ set_null_conf(void)
 				progname, path, strerror(errno));
 		exit_nicely();
 	}
+	free(path);
 }
 
 /*
@@ -1543,6 +1546,9 @@ get_set_pwd(void)
 	PG_CMD_PRINTF2("ALTER USER \"%s\" WITH PASSWORD E'%s';\n",
 				   username, escape_quotes(pwd1));
 
+	/* MM: pwd1 is no longer needed, freeing it */
+	free(pwd1);
+
 	PG_CMD_CLOSE;
 
 	check_ok();

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@`
`42`	`42`	`* Portions Copyright (c) 1994, Regents of the University of California`
`43`	`43`	`* Portions taken from FreeBSD.`
`44`	`44`	`*`
`45`		`- * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.120 2006/07/31 01:16:37 tgl Exp $`
	`45`	`+ * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.121 2006/08/20 16:08:09 meskes Exp $`
`46`	`46`	`*`
`47`	`47`	`*-------------------------------------------------------------------------`
`48`	`48`	`*/`
`@@ -419,6 +419,7 @@ readfile(char *path)`
`419`	`419`	`}`
`420`	`420`
`421`	`421`	`fclose(infile);`
	`422`	`+ free(buffer);`
`422`	`423`	`result[nlines] = NULL;`
`423`	`424`
`424`	`425`	`return result;`
`@@ -1058,6 +1059,7 @@ set_short_version(char short_version, char extrapath)`
`1058`	`1059`	`progname, path, strerror(errno));`
`1059`	`1060`	`exit_nicely();`
`1060`	`1061`	`}`
	`1062`	`+ free(path);`
`1061`	`1063`	`}`
`1062`	`1064`
`1063`	`1065`	`/*`
`@@ -1085,6 +1087,7 @@ set_null_conf(void)`
`1085`	`1087`	`progname, path, strerror(errno));`
`1086`	`1088`	`exit_nicely();`
`1087`	`1089`	`}`
	`1090`	`+ free(path);`
`1088`	`1091`	`}`
`1089`	`1092`
`1090`	`1093`	`/*`
`@@ -1543,6 +1546,9 @@ get_set_pwd(void)`
`1543`	`1546`	`PG_CMD_PRINTF2("ALTER USER \"%s\" WITH PASSWORD E'%s';\n",`
`1544`	`1547`	`username, escape_quotes(pwd1));`
`1545`	`1548`
	`1549`	`+ /* MM: pwd1 is no longer needed, freeing it */`
	`1550`	`+ free(pwd1);`
	`1551`	`+`
`1546`	`1552`	`PG_CMD_CLOSE;`
`1547`	`1553`
`1548`	`1554`	`check_ok();`