Remove dead code

petere · petere · commit 4eb5089e2684 · 2024-08-12T08:52:30.000+02:00
After e9931bf, the locale argument of SB_lower_char() is never NULL, so the branch that deals with NULL can be removed (similar to how e9931bf for example removed those branches in str_tolower()). Reviewed-by: Jeff Davis <pgsql@j-davis.com> Discussion: https://www.postgresql.org/message-id/4f562d84-87f4-44dc-8946-01d6c437936f@eisentraut.org
diff --git a/src/backend/utils/adt/like.c b/src/backend/utils/adt/like.c
@@ -95,10 +95,8 @@ SB_lower_char(unsigned char c, pg_locale_t locale, bool locale_is_c)
 {
 	if (locale_is_c)
 		return pg_ascii_tolower(c);
-	else if (locale)
-		return tolower_l(c, locale->info.lt);
 	else
-		return pg_tolower(c);
+		return tolower_l(c, locale->info.lt);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -95,10 +95,8 @@ SB_lower_char(unsigned char c, pg_locale_t locale, bool locale_is_c)`
`95`	`95`	`{`
`96`	`96`	`if (locale_is_c)`
`97`	`97`	`return pg_ascii_tolower(c);`
`98`		`- else if (locale)`
`99`		`- return tolower_l(c, locale->info.lt);`
`100`	`98`	`else`
`101`		`- return pg_tolower(c);`
	`99`	`+ return tolower_l(c, locale->info.lt);`
`102`	`100`	`}`
`103`	`101`
`104`	`102`