Unbreak legacy syntax "COMMENT ON RULE x IS y", with no relation name.

robertmhaas · robertmhaas · commit 5057366eedac · 2011-08-11T11:23:51.000-04:00
check_object_ownership() isn't happy about the null relation pointer.
We could fix it there, but this seems more future-proof.
diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/objectaddress.c
@@ -498,6 +498,12 @@ get_object_address_relobject(ObjectType objtype, List *objname,
 		address.objectId =
 			get_rewrite_oid_without_relid(depname, &reloid, missing_ok);
 		address.objectSubId = 0;
+
+		/*
+		 * Caller is expecting to get back the relation, even though we
+		 * didn't end up using it to find the rule.
+		 */
+		relation = heap_open(reloid, AccessShareLock);
 	}
 	else
 	{

Original file line number	Diff line number	Diff line change
`@@ -498,6 +498,12 @@ get_object_address_relobject(ObjectType objtype, List *objname,`
`498`	`498`	`address.objectId =`
`499`	`499`	`get_rewrite_oid_without_relid(depname, &reloid, missing_ok);`
`500`	`500`	`address.objectSubId = 0;`
	`501`	`+`
	`502`	`+ /*`
	`503`	`+ * Caller is expecting to get back the relation, even though we`
	`504`	`+ * didn't end up using it to find the rule.`
	`505`	`+ */`
	`506`	`+ relation = heap_open(reloid, AccessShareLock);`
`501`	`507`	`}`
`502`	`508`	`else`
`503`	`509`	`{`