Ensure unlinking of old index file with REINDEX (TABLESPACE)

michaelpq · michaelpq · commit 5128483d0640 · 2021-02-04T17:16:47.000+09:00
The original versions of the patch included this part, but a mismerge from my side has made this piece go missing. Oversight in c5b2860.
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
@@ -3712,6 +3712,12 @@ reindex_index(Oid indexId, bool skip_constraint_checks, char persistence,
 	{
 		/* Update its pg_class row */
 		SetRelationTableSpace(iRel, params->tablespaceOid, InvalidOid);
+
+		/*
+		 * Schedule unlinking of the old index storage at transaction
+		 * commit.
+		 */
+		RelationDropStorage(iRel);
 		RelationAssumeNewRelfilenode(iRel);
 
 		/* Make sure the reltablespace change is visible */
