Fix bad formula in previous commit.

robertmhaas · robertmhaas · commit 5184f110aa41 · 2019-12-17T15:53:17.000-05:00
Commit d5406de used a slightly novel, and wrong, approach to compute the length of the last toast chunk. It worked fine unless the last chunk happened to have the largest possible size.
diff --git a/src/backend/access/common/detoast.c b/src/backend/access/common/detoast.c
@@ -443,7 +443,7 @@ toast_fetch_datum(struct varlena *attr)
 									 toast_pointer.va_valueid,
 									 RelationGetRelationName(toastrel))));
 		expected_size = curchunk < totalchunks - 1 ? TOAST_MAX_CHUNK_SIZE
-			: attrsize % TOAST_MAX_CHUNK_SIZE;
+			: attrsize - ((totalchunks - 1) * TOAST_MAX_CHUNK_SIZE);
 		if (chunksize != expected_size)
 			ereport(ERROR,
 					(errcode(ERRCODE_DATA_CORRUPTED),
@@ -676,7 +676,7 @@ toast_fetch_datum_slice(struct varlena *attr, int32 sliceoffset,
 									 toast_pointer.va_valueid,
 									 RelationGetRelationName(toastrel))));
 		expected_size = curchunk < totalchunks - 1 ? TOAST_MAX_CHUNK_SIZE
-			: attrsize % TOAST_MAX_CHUNK_SIZE;
+			: attrsize - ((totalchunks - 1) * TOAST_MAX_CHUNK_SIZE);
 		if (chunksize != expected_size)
 			ereport(ERROR,
 					(errcode(ERRCODE_DATA_CORRUPTED),
