Fix fd leak in pg_verifybackup

michaelpq · michaelpq · commit 51c388987734 · 2020-12-07T09:30:36.000+09:00
An error code path newly-introduced by 87ae969 forgot to close a file descriptor when verifying a file's checksum. Per report from Coverity, via Tom Lane.
diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c
@@ -730,6 +730,7 @@ verify_file_checksum(verifier_context *context, manifest_file *m,
 	{
 		report_backup_error(context, "could not initialize checksum of file \"%s\"",
 							relpath);
+		close(fd);
 		return;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -730,6 +730,7 @@ verify_file_checksum(verifier_context context, manifest_file m,`
`730`	`730`	`{`
`731`	`731`	`report_backup_error(context, "could not initialize checksum of file \"%s\"",`
`732`	`732`	`relpath);`
	`733`	`+ close(fd);`
`733`	`734`	`return;`
`734`	`735`	`}`
`735`	`736`