Suppress compiler warning in libpq_pipeline.c.

tglsfdc · tglsfdc · commit 522d1a89f8d7 · 2021-03-31T15:30:04.000-04:00
Some compilers seem to be concerned about the possibility that recv_step is not any of the defined enum values. Silence warnings about uninitialized cmdtag in a different way than I did in 9fb9691.
diff --git a/src/test/modules/libpq_pipeline/libpq_pipeline.c b/src/test/modules/libpq_pipeline/libpq_pipeline.c
@@ -646,7 +646,7 @@ test_pipelined_insert(PGconn *conn, int n_rows)
 			while (!PQisBusy(conn) && recv_step < BI_DONE)
 			{
 				PGresult   *res;
-				const char *cmdtag;
+				const char *cmdtag = "";
 				const char *description = "";
 				int			status;
 
@@ -697,7 +697,6 @@ test_pipelined_insert(PGconn *conn, int n_rows)
 					case BI_DONE:
 						/* unreachable */
 						pg_fatal("unreachable state");
-						cmdtag = NULL;	/* keep compiler quiet */
 				}
 
 				if (PQresultStatus(res) != status)

Original file line number	Diff line number	Diff line change
`@@ -646,7 +646,7 @@ test_pipelined_insert(PGconn *conn, int n_rows)`
`646`	`646`	`while (!PQisBusy(conn) && recv_step < BI_DONE)`
`647`	`647`	`{`
`648`	`648`	`PGresult *res;`
`649`		`- const char *cmdtag;`
	`649`	`+ const char *cmdtag = "";`
`650`	`650`	`const char *description = "";`
`651`	`651`	`int status;`
`652`	`652`
`@@ -697,7 +697,6 @@ test_pipelined_insert(PGconn *conn, int n_rows)`
`697`	`697`	`case BI_DONE:`
`698`	`698`	`/* unreachable */`
`699`	`699`	`pg_fatal("unreachable state");`
`700`		`- cmdtag = NULL; /* keep compiler quiet */`
`701`	`700`	`}`
`702`	`701`
`703`	`702`	`if (PQresultStatus(res) != status)`