Add _O_TEXT option to dup2 call on Windows, to ensure redirected postmaster

tglsfdc · tglsfdc · commit 533bd1d5a732 · 2004-08-06T16:06:59.000Z
stderr is in text mode.  Per Andreas.
diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
@@ -18,7 +18,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/postmaster/syslogger.c,v 1.2 2004/08/06 16:00:51 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/postmaster/syslogger.c,v 1.3 2004/08/06 16:06:59 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -495,7 +495,8 @@ SysLogger_Start(void)
 				syslogPipe[1] = -1;
 #else
 				fflush(stderr);
-				if (dup2(_open_osfhandle((long)syslogPipe[1], _O_APPEND),
+				if (dup2(_open_osfhandle((long)syslogPipe[1],
+										 _O_APPEND | _O_TEXT),
 						 _fileno(stderr)) < 0)
 					ereport(FATAL,
 							(errcode_for_file_access(),

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`*`
`19`	`19`	`*`
`20`	`20`	`* IDENTIFICATION`
`21`		`- * $PostgreSQL: pgsql/src/backend/postmaster/syslogger.c,v 1.2 2004/08/06 16:00:51 tgl Exp $`
	`21`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/syslogger.c,v 1.3 2004/08/06 16:06:59 tgl Exp $`
`22`	`22`	`*`
`23`	`23`	`*-------------------------------------------------------------------------`
`24`	`24`	`*/`
`@@ -495,7 +495,8 @@ SysLogger_Start(void)`
`495`	`495`	`syslogPipe[1] = -1;`
`496`	`496`	`#else`
`497`	`497`	`fflush(stderr);`
`498`		`- if (dup2(_open_osfhandle((long)syslogPipe[1], _O_APPEND),`
	`498`	`+ if (dup2(_open_osfhandle((long)syslogPipe[1],`
	`499`	`+ _O_APPEND \| _O_TEXT),`
`499`	`500`	`_fileno(stderr)) < 0)`
`500`	`501`	`ereport(FATAL,`
`501`	`502`	`(errcode_for_file_access(),`