Fix resource leak in initdb -X option

sfrost · sfrost · commit 5461d36b5b7d · 2013-07-14T17:44:29.000-04:00
When creating the symlink for the xlog directory, free the string
which stores the link location.  Not really an issue but it doesn't
hurt to be good about this- prior cleanups have fixed similar
issues.

Leak found by the Coverity scanner.

Not back-patching as I don't see it being worth the code churn.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -3309,6 +3309,7 @@ create_xlog_symlink(void)
 		fprintf(stderr, _("%s: symlinks are not supported on this platform"));
 		exit_nicely();
 #endif
+		free(linkloc);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3309,6 +3309,7 @@ create_xlog_symlink(void)`
`3309`	`3309`	`fprintf(stderr, _("%s: symlinks are not supported on this platform"));`
`3310`	`3310`	`exit_nicely();`
`3311`	`3311`	`#endif`
	`3312`	`+ free(linkloc);`
`3312`	`3313`	`}`
`3313`	`3314`	`}`
`3314`	`3315`