Fix creative, but unportable, spelling of "ptr != NULL".

tglsfdc · tglsfdc · commit 563d575fd733 · 2016-12-12T11:23:23.000-05:00
Or at least I suppose that's what was really meant here.  But even
aside from the not-per-project-style use of "0" to mean "NULL",
I doubt it's safe to assume that all valid pointers are &gt; NULL.
Per buildfarm member pademelon.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -13167,7 +13167,7 @@ ATExecAttachPartition(List **wqueue, Relation rel, PartitionCmd *cmd)
 	tupleDesc = RelationGetDescr(attachRel);
 	attachRel_constr = tupleDesc->constr;
 	existConstraint = NIL;
-	if (attachRel_constr > 0)
+	if (attachRel_constr != NULL)
 	{
 		int			num_check = attachRel_constr->num_check;
 		int			i;

Original file line number	Diff line number	Diff line change
`@@ -13167,7 +13167,7 @@ ATExecAttachPartition(List *wqueue, Relation rel, PartitionCmd cmd)`
`13167`	`13167`	`tupleDesc = RelationGetDescr(attachRel);`
`13168`	`13168`	`attachRel_constr = tupleDesc->constr;`
`13169`	`13169`	`existConstraint = NIL;`
`13170`		`- if (attachRel_constr > 0)`
	`13170`	`+ if (attachRel_constr != NULL)`
`13171`	`13171`	`{`
`13172`	`13172`	`int num_check = attachRel_constr->num_check;`
`13173`	`13173`	`int i;`