Make SyncRepWakeQueue to a static function

tatsuo-ishii · tatsuo-ishii · commit 56abebb9be6d · 2015-03-26T10:39:18.000+09:00
It is only used in src/backend/replication/syncrep.c.

Back-patch to all supported branches except 9.1 which declares the
function as static.
diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c
@@ -68,6 +68,7 @@ static int	SyncRepWaitMode = SYNC_REP_NO_WAIT;
 
 static void SyncRepQueueInsert(int mode);
 static void SyncRepCancelWait(void);
+static int	SyncRepWakeQueue(bool all, int mode);
 
 static int	SyncRepGetStandbyPriority(void);
 
@@ -523,7 +524,7 @@ SyncRepGetStandbyPriority(void)
  *
  * Must hold SyncRepLock.
  */
-int
+static int
 SyncRepWakeQueue(bool all, int mode)
 {
 	volatile WalSndCtlData *walsndctl = WalSndCtl;
diff --git a/src/include/replication/syncrep.h b/src/include/replication/syncrep.h
@@ -47,9 +47,6 @@ extern void SyncRepReleaseWaiters(void);
 /* called by checkpointer */
 extern void SyncRepUpdateSyncStandbysDefined(void);
 
-/* called by various procs */
-extern int	SyncRepWakeQueue(bool all, int mode);
-
 extern bool check_synchronous_standby_names(char **newval, void **extra, GucSource source);
 extern void assign_synchronous_commit(int newval, void *extra);
 

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ static int SyncRepWaitMode = SYNC_REP_NO_WAIT;`
`68`	`68`
`69`	`69`	`static void SyncRepQueueInsert(int mode);`
`70`	`70`	`static void SyncRepCancelWait(void);`
	`71`	`+static int SyncRepWakeQueue(bool all, int mode);`
`71`	`72`
`72`	`73`	`static int SyncRepGetStandbyPriority(void);`
`73`	`74`
`@@ -523,7 +524,7 @@ SyncRepGetStandbyPriority(void)`
`523`	`524`	`*`
`524`	`525`	`* Must hold SyncRepLock.`
`525`	`526`	`*/`
`526`		`-int`
	`527`	`+static int`
`527`	`528`	`SyncRepWakeQueue(bool all, int mode)`
`528`	`529`	`{`
`529`	`530`	`volatile WalSndCtlData *walsndctl = WalSndCtl;`