Avoid file descriptor leak in pg_test_fsync.

robertmhaas · robertmhaas · commit 57ce746617b6 · 2014-11-19T12:20:47.000-05:00
This can cause problems on Windows, where files that are still open
can't be unlinked.

Jeff Janes
diff --git a/contrib/pg_test_fsync/pg_test_fsync.c b/contrib/pg_test_fsync/pg_test_fsync.c
@@ -258,8 +258,6 @@ test_sync(int writes_per_op)
 	}
 	else
 	{
-		if ((tmpfile = open(filename, O_RDWR | O_DSYNC | PG_O_DIRECT, 0)) == -1)
-			die("could not open output file");
 		START_TIMER;
 		for (ops = 0; alarm_triggered == false; ops++)
 		{

Original file line number	Diff line number	Diff line change
`@@ -258,8 +258,6 @@ test_sync(int writes_per_op)`
`258`	`258`	`}`
`259`	`259`	`else`
`260`	`260`	`{`
`261`		`- if ((tmpfile = open(filename, O_RDWR \| O_DSYNC \| PG_O_DIRECT, 0)) == -1)`
`262`		`- die("could not open output file");`
`263`	`261`	`START_TIMER;`
`264`	`262`	`for (ops = 0; alarm_triggered == false; ops++)`
`265`	`263`	`{`