psql: Remove inappropriate const qualifiers

petere · petere · commit 598bb8cdbd9c · 2012-03-16T20:35:00.000+02:00
Since mbvalidate() can alter the string it validates, having the
callers claim that the strings they accept are const is inappropriate.
diff --git a/src/bin/psql/mbprint.c b/src/bin/psql/mbprint.c
@@ -385,7 +385,7 @@ unsigned char *
 mbvalidate(unsigned char *pwcs, int encoding)
 {
 	if (encoding == PG_UTF8)
-		mb_utf_validate((unsigned char *) pwcs);
+		mb_utf_validate(pwcs);
 	else
 	{
 		/*
diff --git a/src/bin/psql/print.c b/src/bin/psql/print.c
@@ -2122,7 +2122,7 @@ printTableInit(printTableContent *const content, const printTableOpt *opt,
  * column.
  */
 void
-printTableAddHeader(printTableContent *const content, const char *header,
+printTableAddHeader(printTableContent *const content, char *header,
 					const bool translate, const char align)
 {
 #ifndef ENABLE_NLS
@@ -2162,7 +2162,7 @@ printTableAddHeader(printTableContent *const content, const char *header,
  * Note: Automatic freeing of translatable strings is not supported.
  */
 void
-printTableAddCell(printTableContent *const content, const char *cell,
+printTableAddCell(printTableContent *const content, char *cell,
 				  const bool translate, const bool mustfree)
 {
 #ifndef ENABLE_NLS
diff --git a/src/bin/psql/print.h b/src/bin/psql/print.h
@@ -162,9 +162,9 @@ extern void printTableInit(printTableContent *const content,
 			   const printTableOpt *opt, const char *title,
 			   const int ncolumns, const int nrows);
 extern void printTableAddHeader(printTableContent *const content,
-				 const char *header, const bool translate, const char align);
+				 char *header, const bool translate, const char align);
 extern void printTableAddCell(printTableContent *const content,
-				const char *cell, const bool translate, const bool mustfree);
+				char *cell, const bool translate, const bool mustfree);
 extern void printTableAddFooter(printTableContent *const content,
 					const char *footer);
 extern void printTableSetFooter(printTableContent *const content,

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ unsigned char *`
`385`	`385`	`mbvalidate(unsigned char *pwcs, int encoding)`
`386`	`386`	`{`
`387`	`387`	`if (encoding == PG_UTF8)`
`388`		`- mb_utf_validate((unsigned char *) pwcs);`
	`388`	`+ mb_utf_validate(pwcs);`
`389`	`389`	`else`
`390`	`390`	`{`
`391`	`391`	`/*`