Quiet repeated "loaded library" messages from child backends that are just

tglsfdc · tglsfdc · commit 5993bcaf41db · 2009-01-05T13:57:12.000Z
re-loading a library already loaded into the postmaster.

ITAGAKI Takahiro
diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/init/miscinit.c,v 1.171 2009/01/03 20:03:08 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/init/miscinit.c,v 1.172 2009/01/05 13:57:12 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1145,6 +1145,7 @@ load_libraries(const char *libraries, const char *gucname, bool restricted)
 {
 	char	   *rawstring;
 	List	   *elemlist;
+	int			elevel;
 	ListCell   *l;
 
 	if (libraries == NULL || libraries[0] == '\0')
@@ -1166,6 +1167,18 @@ load_libraries(const char *libraries, const char *gucname, bool restricted)
 		return;
 	}
 
+	/*
+	 * Choose notice level: avoid repeat messages when re-loading a library
+	 * that was preloaded into the postmaster.  (Only possible in EXEC_BACKEND
+	 * configurations)
+	 */
+#ifdef EXEC_BACKEND
+	if (IsUnderPostmaster && process_shared_preload_libraries_in_progress)
+		elevel = DEBUG2;
+	else
+#endif
+		elevel = LOG;
+
 	foreach(l, elemlist)
 	{
 		char	   *tok = (char *) lfirst(l);
@@ -1185,7 +1198,7 @@ load_libraries(const char *libraries, const char *gucname, bool restricted)
 			filename = expanded;
 		}
 		load_file(filename, restricted);
-		ereport(LOG,
+		ereport(elevel,
 				(errmsg("loaded library \"%s\"", filename)));
 		pfree(filename);
 	}

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/init/miscinit.c,v 1.171 2009/01/03 20:03:08 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/init/miscinit.c,v 1.172 2009/01/05 13:57:12 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1145,6 +1145,7 @@ load_libraries(const char libraries, const char gucname, bool restricted)`
`1145`	`1145`	`{`
`1146`	`1146`	`char *rawstring;`
`1147`	`1147`	`List *elemlist;`
	`1148`	`+ int elevel;`
`1148`	`1149`	`ListCell *l;`
`1149`	`1150`
`1150`	`1151`	`if (libraries == NULL \|\| libraries[0] == '\0')`
`@@ -1166,6 +1167,18 @@ load_libraries(const char libraries, const char gucname, bool restricted)`
`1166`	`1167`	`return;`
`1167`	`1168`	`}`
`1168`	`1169`
	`1170`	`+ /*`
	`1171`	`+ * Choose notice level: avoid repeat messages when re-loading a library`
	`1172`	`+ * that was preloaded into the postmaster. (Only possible in EXEC_BACKEND`
	`1173`	`+ * configurations)`
	`1174`	`+ */`
	`1175`	`+#ifdef EXEC_BACKEND`
	`1176`	`+ if (IsUnderPostmaster && process_shared_preload_libraries_in_progress)`
	`1177`	`+ elevel = DEBUG2;`
	`1178`	`+ else`
	`1179`	`+#endif`
	`1180`	`+ elevel = LOG;`
	`1181`	`+`
`1169`	`1182`	`foreach(l, elemlist)`
`1170`	`1183`	`{`
`1171`	`1184`	`char tok = (char ) lfirst(l);`
`@@ -1185,7 +1198,7 @@ load_libraries(const char libraries, const char gucname, bool restricted)`
`1185`	`1198`	`filename = expanded;`
`1186`	`1199`	`}`
`1187`	`1200`	`load_file(filename, restricted);`
`1188`		`- ereport(LOG,`
	`1201`	`+ ereport(elevel,`
`1189`	`1202`	`(errmsg("loaded library \"%s\"", filename)));`
`1190`	`1203`	`pfree(filename);`
`1191`	`1204`	`}`