MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS.

nmisch · nmisch · commit 5a2398b0b2d3 · 2020-06-07T16:27:13.000-07:00
Commit 7be5d8d surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch to 9.5 (all supported versions).
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -198,7 +198,7 @@ sub tap_check
 	  unless $config->{tap_tests};
 
 	my @flags;
-	foreach my $arg (0 .. scalar(@_))
+	foreach my $arg (0 .. scalar(@_) - 1)
 	{
 		next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;
 		@flags = split(/\s+/, $1);

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ sub tap_check`
`198`	`198`	`unless $config->{tap_tests};`
`199`	`199`
`200`	`200`	`my @flags;`
`201`		`- foreach my $arg (0 .. scalar(@_))`
	`201`	`+ foreach my $arg (0 .. scalar(@_) - 1)`
`202`	`202`	`{`
`203`	`203`	`next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;`
`204`	`204`	`@flags = split(/\s+/, $1);`