Update krb_server_name to document that a missing entry defaults to

bmomjian · bmomjian · commit 5aae047e239c · 2005-10-13T22:55:19.000Z
'localhost'.

Improve kerberos error message.
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
@@ -1,5 +1,5 @@
 <!--
-$PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.27 2005/10/13 20:58:42 momjian Exp $
+$PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.28 2005/10/13 22:55:19 momjian Exp $
 -->
 <chapter Id="runtime-config">
   <title>Run-time Configuration</title>
@@ -596,9 +596,8 @@ SET ENABLE_SEQSCAN TO OFF;
         <varname>krb_srvname</><literal>/</><varname>krb_server_hostname</><literal>@</>REALM.
        </para>
        <para>
-        If not set, the default is to allow any service principal matching an entry
-        in the keytab.  See <xref linkend="kerberos-auth"> for details.
-        This parameter can only be set at server start.
+        If not set, the default is <literal>localhost</>.  See <xref linkend="kerberos-auth">
+        for details.  This parameter can only be set at server start.
        </para>
       </listitem>
      </varlistentry>
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/libpq/auth.c,v 1.128 2005/10/08 19:32:57 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/libpq/auth.c,v 1.129 2005/10/13 22:55:19 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -162,11 +162,11 @@ pg_krb5_init(void)
 	if (retval)
 	{
 		ereport(LOG,
-				(errmsg("Kerberos sname_to_principal(\"%s\") returned error %d",
-						pg_krb_srvnam, retval)));
+				(errmsg("Kerberos sname_to_principal(\"%s\", \"%s\") returned error %d",
+						khostname ? khostname : "localhost", pg_krb_srvnam, retval)));
 		com_err("postgres", retval,
-				"while getting server principal for service \"%s\"",
-				pg_krb_srvnam);
+				"while getting server principal for server \"%s\" for service \"%s\"",
+				khostname ? khostname : "localhost", pg_krb_srvnam);
 		krb5_kt_close(pg_krb5_context, pg_krb5_keytab);
 		krb5_free_context(pg_krb5_context);
 		return STATUS_ERROR;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/libpq/auth.c,v 1.128 2005/10/08 19:32:57 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/libpq/auth.c,v 1.129 2005/10/13 22:55:19 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -162,11 +162,11 @@ pg_krb5_init(void)`
`162`	`162`	`if (retval)`
`163`	`163`	`{`
`164`	`164`	`ereport(LOG,`
`165`		`- (errmsg("Kerberos sname_to_principal(\"%s\") returned error %d",`
`166`		`- pg_krb_srvnam, retval)));`
	`165`	`+ (errmsg("Kerberos sname_to_principal(\"%s\", \"%s\") returned error %d",`
	`166`	`+ khostname ? khostname : "localhost", pg_krb_srvnam, retval)));`
`167`	`167`	`com_err("postgres", retval,`
`168`		`- "while getting server principal for service \"%s\"",`
`169`		`- pg_krb_srvnam);`
	`168`	`+ "while getting server principal for server \"%s\" for service \"%s\"",`
	`169`	`+ khostname ? khostname : "localhost", pg_krb_srvnam);`
`170`	`170`	`krb5_kt_close(pg_krb5_context, pg_krb5_keytab);`
`171`	`171`	`krb5_free_context(pg_krb5_context);`
`172`	`172`	`return STATUS_ERROR;`