Add missing ReleaseBuffer call in BRIN revmap code

alvherre · alvherre · commit 5cd653834585 · 2015-09-11T15:29:46.000-03:00
I think this particular branch is actually dead, but the analysis to
prove that is not trivial, so instead take the weasel way.

Reported by Jinyu Zhang
Backpatch to 9.5, where BRIN was introduced.
diff --git a/src/backend/access/brin/brin_revmap.c b/src/backend/access/brin/brin_revmap.c
@@ -432,6 +432,7 @@ revmap_physical_extend(BrinRevmap *revmap)
 			if (needLock)
 				UnlockRelationForExtension(irel, ExclusiveLock);
 			LockBuffer(revmap->rm_metaBuf, BUFFER_LOCK_UNLOCK);
+			ReleaseBuffer(buf);
 			return;
 		}
 		LockBuffer(buf, BUFFER_LOCK_EXCLUSIVE);

Original file line number	Diff line number	Diff line change
`@@ -432,6 +432,7 @@ revmap_physical_extend(BrinRevmap *revmap)`
`432`	`432`	`if (needLock)`
`433`	`433`	`UnlockRelationForExtension(irel, ExclusiveLock);`
`434`	`434`	`LockBuffer(revmap->rm_metaBuf, BUFFER_LOCK_UNLOCK);`
	`435`	`+ ReleaseBuffer(buf);`
`435`	`436`	`return;`
`436`	`437`	`}`
`437`	`438`	`LockBuffer(buf, BUFFER_LOCK_EXCLUSIVE);`