Focus on ftello result < 0 instead of errno

sfrost · sfrost · commit 5e8e794e3be9 · 2014-02-09T13:29:36.000-05:00
Rather than reset errno (or just hope that its cleared already),
check just the result of the ftello for &lt; 0 to determine if there
was an issue.

Oversight by me, pointed out by Tom.
diff --git a/src/bin/pg_dump/pg_backup_custom.c b/src/bin/pg_dump/pg_backup_custom.c
@@ -708,7 +708,7 @@ _CloseArchive(ArchiveHandle *AH)
 	{
 		WriteHead(AH);
 		tpos = ftello(AH->FH);
-		if (tpos < 0 || errno)
+		if (tpos < 0)
 			exit_horribly(modulename, "could not determine seek position in archive file: %s\n",
 						  strerror(errno));
 		WriteToc(AH);
@@ -757,9 +757,8 @@ _ReopenArchive(ArchiveHandle *AH)
 	if (!ctx->hasSeek)
 		exit_horribly(modulename, "parallel restore from non-seekable file is not supported\n");
 
-	errno = 0;
 	tpos = ftello(AH->FH);
-	if (tpos < 0 || errno)
+	if (tpos < 0)
 		exit_horribly(modulename, "could not determine seek position in archive file: %s\n",
 					  strerror(errno));
 
