Remove wal_keep_segments from default configuration in PostgresNode.pm

petere · petere · commit 5eb8bf2d4267 · 2017-11-02T12:38:59.000-04:00
This is only used in the pg_rewind tests, so only set it there.  It's
better if other tests run closer to a default configuration.

Author: Michael Paquier &lt;michael.paquier@gmail.com&gt;
diff --git a/src/bin/pg_rewind/RewindTest.pm b/src/bin/pg_rewind/RewindTest.pm
@@ -119,6 +119,11 @@ sub setup_cluster
 	# Initialize master, data checksums are mandatory
 	$node_master = get_new_node('master' . ($extra_name ? "_${extra_name}" : ''));
 	$node_master->init(allows_streaming => 1);
+	# Set wal_keep_segments to prevent WAL segment recycling after enforced
+	# checkpoints in the tests.
+	$node_master->append_conf('postgresql.conf', qq(
+wal_keep_segments = 20
+));
 }
 
 sub start_master
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
@@ -435,7 +435,6 @@ sub init
 		}
 		print $conf "max_wal_senders = 5\n";
 		print $conf "max_replication_slots = 5\n";
-		print $conf "wal_keep_segments = 20\n";
 		print $conf "max_wal_size = 128MB\n";
 		print $conf "shared_buffers = 1MB\n";
 		print $conf "wal_log_hints = on\n";

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,6 @@ sub init`
`435`	`435`	`}`
`436`	`436`	`print $conf "max_wal_senders = 5\n";`
`437`	`437`	`print $conf "max_replication_slots = 5\n";`
`438`		`- print $conf "wal_keep_segments = 20\n";`
`439`	`438`	`print $conf "max_wal_size = 128MB\n";`
`440`	`439`	`print $conf "shared_buffers = 1MB\n";`
`441`	`440`	`print $conf "wal_log_hints = on\n";`