Report WAL flush, not insert, position in replication IDENTIFY_SYSTEM

hlinnaka · hlinnaka · commit 5f0ba4abb336 · 2015-02-06T11:32:16.000+02:00
When beginning streaming replication, the client usually issues the
IDENTIFY_SYSTEM command, which used to return the current WAL insert
position. That's not suitable for the intended purpose of that field,
however. pg_receivexlog uses it to start replication from the reported
point, but if it hasn't been flushed to disk yet, it will fail. Change
IDENTIFY_SYSTEM to report the flush position instead.

Backpatch to 9.1 and above. 9.0 doesn't report any WAL position.
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
@@ -1350,7 +1350,7 @@ The commands accepted in walsender mode are:
       </term>
       <listitem>
       <para>
-       Current xlog write location. Useful to get a known location in the
+       Current xlog flush location. Useful to get a known location in the
        transaction log where streaming can start.
       </para>
       </listitem>
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
@@ -259,7 +259,7 @@ IdentifySystem(void)
 		logptr = GetStandbyFlushRecPtr();
 	}
 	else
-		logptr = GetInsertRecPtr();
+		logptr = GetFlushRecPtr();
 
 	snprintf(tli, sizeof(tli), "%u", ThisTimeLineID);
 

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,7 @@ IdentifySystem(void)`
`259`	`259`	`logptr = GetStandbyFlushRecPtr();`
`260`	`260`	`}`
`261`	`261`	`else`
`262`		`- logptr = GetInsertRecPtr();`
	`262`	`+ logptr = GetFlushRecPtr();`
`263`	`263`
`264`	`264`	`snprintf(tli, sizeof(tli), "%u", ThisTimeLineID);`
`265`	`265`