Fix compiler warning in the proper way.

bmomjian · bmomjian · commit 640d0dc0f02c · 2004-08-08T07:00:22.000Z
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  *
- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.48 2004/08/08 06:58:00 momjian Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.49 2004/08/08 07:00:22 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -870,9 +870,10 @@ runPgDump(const char *dbname)
 	appendPQExpBufferChar(cmd, '\'');
 #else
 	appendPQExpBufferChar(cmd, '"');
-	appendPQExpBuffer(cmd, SYSTEMQUOTE);
 #endif
 	
+	appendPQExpBuffer(cmd, "%s", SYSTEMQUOTE);
+
 	if (verbose)
 		fprintf(stderr, _("%s: running \"%s\"\n"), progname, cmd->data);
 

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* Portions Copyright (c) 1994, Regents of the University of California`
`7`	`7`	`*`
`8`	`8`	`*`
`9`		`- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.48 2004/08/08 06:58:00 momjian Exp $`
	`9`	`+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.49 2004/08/08 07:00:22 momjian Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -870,9 +870,10 @@ runPgDump(const char *dbname)`
`870`	`870`	`appendPQExpBufferChar(cmd, '\'');`
`871`	`871`	`#else`
`872`	`872`	`appendPQExpBufferChar(cmd, '"');`
`873`		`- appendPQExpBuffer(cmd, SYSTEMQUOTE);`
`874`	`873`	`#endif`
`875`	`874`
	`875`	`+ appendPQExpBuffer(cmd, "%s", SYSTEMQUOTE);`
	`876`	`+`
`876`	`877`	`if (verbose)`
`877`	`878`	`fprintf(stderr, _("%s: running \"%s\"\n"), progname, cmd->data);`
`878`	`879`