winsock_strerror crashed on me. This fixes a line of code that looks

tglsfdc · tglsfdc · commit 650c17504212 · 2001-09-30T16:23:30.000Z
cleverer than it actually is ;-) Braces are good for you :-)

Gerhard HÌring
diff --git a/src/interfaces/libpq/fe-misc.c b/src/interfaces/libpq/fe-misc.c
@@ -25,7 +25,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.56 2001/09/06 04:57:30 ishii Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.57 2001/09/30 16:23:30 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -892,7 +892,7 @@ winsock_strerror(DWORD eno)
 WSSE_GOODEXIT:
 
   length = strlen(winsock_strerror_buf);
-  sprintf(winsock_strerror_buf + length<WSSE_MAXLEN?length:WSSE_MAXLEN,
+  sprintf(winsock_strerror_buf + (length<WSSE_MAXLEN?length:WSSE_MAXLEN),
 	  "(0x%08X)",eno);
 
   return winsock_strerror_buf;

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`*`
`26`	`26`	`*`
`27`	`27`	`* IDENTIFICATION`
`28`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.56 2001/09/06 04:57:30 ishii Exp $`
	`28`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.57 2001/09/30 16:23:30 tgl Exp $`
`29`	`29`	`*`
`30`	`30`	`*-------------------------------------------------------------------------`
`31`	`31`	`*/`
`@@ -892,7 +892,7 @@ winsock_strerror(DWORD eno)`
`892`	`892`	`WSSE_GOODEXIT:`
`893`	`893`
`894`	`894`	`length = strlen(winsock_strerror_buf);`
`895`		`- sprintf(winsock_strerror_buf + length<WSSE_MAXLEN?length:WSSE_MAXLEN,`
	`895`	`+ sprintf(winsock_strerror_buf + (length<WSSE_MAXLEN?length:WSSE_MAXLEN),`
`896`	`896`	`"(0x%08X)",eno);`
`897`	`897`
`898`	`898`	`return winsock_strerror_buf;`