psql: Add test for handling of replication commands

petere · petere · commit 67c069848a99 · 2021-10-12T15:33:36.000+02:00
Add a test for the clean handling of unsupported replication command responses. This was once accidentally broken, and it seems unusual enough that it's easy to forget when testing manually. Discussion: https://www.postgresql.org/message-id/2570e2ae-fa0f-aac9-f72f-bb59a9983a20@enterprisedb.com
diff --git a/src/bin/psql/t/001_basic.pl b/src/bin/psql/t/001_basic.pl
@@ -6,7 +6,7 @@
 
 use PostgresNode;
 use TestLib;
-use Test::More tests => 23;
+use Test::More tests => 25;
 
 program_help_ok('psql');
 program_version_ok('psql');
@@ -26,8 +26,19 @@
 
 my $node = PostgresNode->new('main');
 $node->init;
+$node->append_conf(
+	'postgresql.conf', q{
+wal_level = 'logical'
+max_replication_slots = 4
+max_wal_senders = 4
+});
 $node->start;
 
 $node->command_like([ 'psql', '-c', '\copyright' ], qr/Copyright/, '\copyright');
 $node->command_like([ 'psql', '-c', '\help' ], qr/ALTER/, '\help without arguments');
 $node->command_like([ 'psql', '-c', '\help SELECT' ], qr/SELECT/, '\help');
+
+
+# Test clean handling of unsupported replication command responses
+$node->command_fails_like([ 'psql', 'replication=database', '-c', 'START_REPLICATION 0/0' ],
+	qr/^unexpected PQresultStatus: 8$/, 'handling of unexpected PQresultStatus');
