backend: Fix minor memory leak in configuration file processing

petere · petere · commit 693ff85d4718 · 2012-03-16T20:34:59.000+02:00
Just for consistency with the other code paths.

found by Coverity
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -4095,6 +4095,7 @@ SelectConfigFiles(const char *userDoption, const char *progname)
 	{
 		write_stderr("%s cannot access the server configuration file \"%s\": %s\n",
 					 progname, ConfigFileName, strerror(errno));
+		free(configdir);
 		return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -4095,6 +4095,7 @@ SelectConfigFiles(const char userDoption, const char progname)`
`4095`	`4095`	`{`
`4096`	`4096`	`write_stderr("%s cannot access the server configuration file \"%s\": %s\n",`
`4097`	`4097`	`progname, ConfigFileName, strerror(errno));`
	`4098`	`+ free(configdir);`
`4098`	`4099`	`return false;`
`4099`	`4100`	`}`
`4100`	`4101`