I've found a memory leak in libecpg of PostgreSQL 7.0.3.

bmomjian · bmomjian · commit 6b75942c7216 · 2001-01-02T22:03:02.000Z
The leak is caused by the memory allocation in
src/interfaces/ecpg/lib/execute.c in line 669 which is never freed.
Adding a "free(array_query);" after PQexec in line 671 seems to fix the
leak.

Thorsten Knabe
diff --git a/src/interfaces/ecpg/lib/execute.c b/src/interfaces/ecpg/lib/execute.c
@@ -341,6 +341,7 @@ ECPGis_type_an_array(int type,const struct statement * stmt,const struct variabl
 	array_query = (char *) ecpg_alloc(strlen("select typelem from pg_type where oid=") + 11, stmt->lineno);
 	sprintf(array_query, "select typelem from pg_type where oid=%d", type);
 	query = PQexec(stmt->connection->connection, array_query);
+	free(array_query);
 	if (PQresultStatus(query) == PGRES_TUPLES_OK)
 	{
 		isarray = atol((char *) PQgetvalue(query, 0, 0));
@@ -1005,7 +1006,7 @@ ECPGdo(int lineno, const char *connection_name, char *query,...)
  *
  * Copyright (c) 2000, Christof Petig <christof.petig@wtal.de>
  *
- * $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/execute.c,v 1.15 2000/12/18 11:33:54 meskes Exp $
+ * $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/execute.c,v 1.16 2001/01/02 22:03:02 momjian Exp $
  */
 
 PGconn	   *ECPG_internal_get_connection(char *name);

Original file line number	Diff line number	Diff line change
`@@ -341,6 +341,7 @@ ECPGis_type_an_array(int type,const struct statement * stmt,const struct variabl`
`341`	`341`	`array_query = (char *) ecpg_alloc(strlen("select typelem from pg_type where oid=") + 11, stmt->lineno);`
`342`	`342`	`sprintf(array_query, "select typelem from pg_type where oid=%d", type);`
`343`	`343`	`query = PQexec(stmt->connection->connection, array_query);`
	`344`	`+ free(array_query);`
`344`	`345`	`if (PQresultStatus(query) == PGRES_TUPLES_OK)`
`345`	`346`	`{`
`346`	`347`	`isarray = atol((char *) PQgetvalue(query, 0, 0));`
`@@ -1005,7 +1006,7 @@ ECPGdo(int lineno, const char connection_name, char query,...)`
`1005`	`1006`	`*`
`1006`	`1007`	`* Copyright (c) 2000, Christof Petig <christof.petig@wtal.de>`
`1007`	`1008`	`*`
`1008`		`- * $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/execute.c,v 1.15 2000/12/18 11:33:54 meskes Exp $`
	`1009`	`+ * $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/execute.c,v 1.16 2001/01/02 22:03:02 momjian Exp $`
`1009`	`1010`	`*/`
`1010`	`1011`
`1011`	`1012`	`PGconn ECPG_internal_get_connection(char name);`