Make GUC_check_errdetail messages full sentences

alvherre · alvherre · commit 6ba9892f5cb8 · 2024-11-27T19:49:36.000+01:00
They were all missing punctuation, one was missing initial capital.
Per our message style guidelines.

No backpatch, to avoid breaking existing translations.
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c
@@ -358,7 +358,7 @@ check_slru_buffers(const char *name, int *newval)
 	if (*newval % SLRU_BANK_SIZE == 0)
 		return true;
 
-	GUC_check_errdetail("\"%s\" must be a multiple of %d", name,
+	GUC_check_errdetail("\"%s\" must be a multiple of %d.", name,
 						SLRU_BANK_SIZE);
 	return false;
 }
diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.c
@@ -4933,7 +4933,7 @@ check_recovery_target_time(char **newval, void **extra, GucSource source)
 
 			if (tm2timestamp(tm, fsec, &tz, &timestamp) != 0)
 			{
-				GUC_check_errdetail("timestamp out of range: \"%s\"", str);
+				GUC_check_errdetail("Timestamp out of range: \"%s\".", str);
 				return false;
 			}
 		}
diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c
@@ -130,7 +130,8 @@ check_vacuum_buffer_usage_limit(int *newval, void **extra,
 		return true;
 
 	/* Value does not fall within any allowable range */
-	GUC_check_errdetail("\"vacuum_buffer_usage_limit\" must be 0 or between %d kB and %d kB",
+	GUC_check_errdetail("\"%s\" must be 0 or between %d kB and %d kB.",
+						"vacuum_buffer_usage_limit",
 						MIN_BAS_VAC_RING_SIZE_KB, MAX_BAS_VAC_RING_SIZE_KB);
 
 	return false;
diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
@@ -2478,15 +2478,15 @@ validate_sync_standby_slots(char *rawname, List **elemlist)
 
 			if (!slot)
 			{
-				GUC_check_errdetail("replication slot \"%s\" does not exist",
+				GUC_check_errdetail("Replication slot \"%s\" does not exist.",
 									name);
 				ok = false;
 				break;
 			}
 
 			if (!SlotIsPhysical(slot))
 			{
-				GUC_check_errdetail("\"%s\" is not a physical replication slot",
+				GUC_check_errdetail("\"%s\" is not a physical replication slot.",
 									name);
 				ok = false;
 				break;
diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c
@@ -1010,7 +1010,8 @@ check_synchronous_standby_names(char **newval, void **extra, GucSource source)
 			if (syncrep_parse_error_msg)
 				GUC_check_errdetail("%s", syncrep_parse_error_msg);
 			else
-				GUC_check_errdetail("\"synchronous_standby_names\" parser failed");
+				GUC_check_errdetail("\"%s\" parser failed.",
+									"synchronous_standby_names");
 			return false;
 		}
 
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -3985,7 +3985,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 
 	if (!SplitGUCList(rawstring, ',', &elemlist))
 	{
-		GUC_check_errdetail("Invalid list syntax in parameter \"%s\"",
+		GUC_check_errdetail("Invalid list syntax in parameter \"%s\".",
 							"debug_io_direct");
 		pfree(rawstring);
 		list_free(elemlist);
@@ -4005,7 +4005,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 			flags |= IO_DIRECT_WAL_INIT;
 		else
 		{
-			GUC_check_errdetail("Invalid option \"%s\"", item);
+			GUC_check_errdetail("Invalid option \"%s\".", item);
 			result = false;
 			break;
 		}
@@ -4018,15 +4018,15 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 #if XLOG_BLCKSZ < PG_IO_ALIGN_SIZE
 	if (result && (flags & (IO_DIRECT_WAL | IO_DIRECT_WAL_INIT)))
 	{
-		GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small",
+		GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small.",
 							"debug_io_direct", "XLOG_BLCKSZ");
 		result = false;
 	}
 #endif
 #if BLCKSZ < PG_IO_ALIGN_SIZE
 	if (result && (flags & IO_DIRECT_DATA))
 	{
-		GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small",
+		GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small.",
 							"debug_io_direct", "BLCKSZ");
 		result = false;
 	}
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
@@ -2183,7 +2183,7 @@ check_backtrace_functions(char **newval, void **extra, GucSource source)
 					  ", \n\t");
 	if (validlen != newvallen)
 	{
-		GUC_check_errdetail("Invalid character");
+		GUC_check_errdetail("Invalid character.");
 		return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ check_slru_buffers(const char name, int newval)`
`358`	`358`	`if (*newval % SLRU_BANK_SIZE == 0)`
`359`	`359`	`return true;`
`360`	`360`
`361`		`- GUC_check_errdetail("\"%s\" must be a multiple of %d", name,`
	`361`	`+ GUC_check_errdetail("\"%s\" must be a multiple of %d.", name,`
`362`	`362`	`SLRU_BANK_SIZE);`
`363`	`363`	`return false;`
`364`	`364`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4933,7 +4933,7 @@ check_recovery_target_time(char newval, void extra, GucSource source)`
`4933`	`4933`
`4934`	`4934`	`if (tm2timestamp(tm, fsec, &tz, &timestamp) != 0)`
`4935`	`4935`	`{`
`4936`		`- GUC_check_errdetail("timestamp out of range: \"%s\"", str);`
	`4936`	`+ GUC_check_errdetail("Timestamp out of range: \"%s\".", str);`
`4937`	`4937`	`return false;`
`4938`	`4938`	`}`
`4939`	`4939`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2478,15 +2478,15 @@ validate_sync_standby_slots(char rawname, List *elemlist)`
`2478`	`2478`
`2479`	`2479`	`if (!slot)`
`2480`	`2480`	`{`
`2481`		`- GUC_check_errdetail("replication slot \"%s\" does not exist",`
	`2481`	`+ GUC_check_errdetail("Replication slot \"%s\" does not exist.",`
`2482`	`2482`	`name);`
`2483`	`2483`	`ok = false;`
`2484`	`2484`	`break;`
`2485`	`2485`	`}`
`2486`	`2486`
`2487`	`2487`	`if (!SlotIsPhysical(slot))`
`2488`	`2488`	`{`
`2489`		`- GUC_check_errdetail("\"%s\" is not a physical replication slot",`
	`2489`	`+ GUC_check_errdetail("\"%s\" is not a physical replication slot.",`
`2490`	`2490`	`name);`
`2491`	`2491`	`ok = false;`
`2492`	`2492`	`break;`
Original file line number	Diff line number	Diff line change
`@@ -1010,7 +1010,8 @@ check_synchronous_standby_names(char newval, void extra, GucSource source)`
`1010`	`1010`	`if (syncrep_parse_error_msg)`
`1011`	`1011`	`GUC_check_errdetail("%s", syncrep_parse_error_msg);`
`1012`	`1012`	`else`
`1013`		`- GUC_check_errdetail("\"synchronous_standby_names\" parser failed");`
	`1013`	`+ GUC_check_errdetail("\"%s\" parser failed.",`
	`1014`	`+ "synchronous_standby_names");`
`1014`	`1015`	`return false;`
`1015`	`1016`	`}`
`1016`	`1017`
Original file line number	Diff line number	Diff line change
`@@ -3985,7 +3985,7 @@ check_debug_io_direct(char newval, void extra, GucSource source)`
`3985`	`3985`
`3986`	`3986`	`if (!SplitGUCList(rawstring, ',', &elemlist))`
`3987`	`3987`	`{`
`3988`		`- GUC_check_errdetail("Invalid list syntax in parameter \"%s\"",`
	`3988`	`+ GUC_check_errdetail("Invalid list syntax in parameter \"%s\".",`
`3989`	`3989`	`"debug_io_direct");`
`3990`	`3990`	`pfree(rawstring);`
`3991`	`3991`	`list_free(elemlist);`
`@@ -4005,7 +4005,7 @@ check_debug_io_direct(char newval, void extra, GucSource source)`
`4005`	`4005`	`flags \|= IO_DIRECT_WAL_INIT;`
`4006`	`4006`	`else`
`4007`	`4007`	`{`
`4008`		`- GUC_check_errdetail("Invalid option \"%s\"", item);`
	`4008`	`+ GUC_check_errdetail("Invalid option \"%s\".", item);`
`4009`	`4009`	`result = false;`
`4010`	`4010`	`break;`
`4011`	`4011`	`}`
`@@ -4018,15 +4018,15 @@ check_debug_io_direct(char newval, void extra, GucSource source)`
`4018`	`4018`	`#if XLOG_BLCKSZ < PG_IO_ALIGN_SIZE`
`4019`	`4019`	`if (result && (flags & (IO_DIRECT_WAL \| IO_DIRECT_WAL_INIT)))`
`4020`	`4020`	`{`
`4021`		`- GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small",`
	`4021`	`+ GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small.",`
`4022`	`4022`	`"debug_io_direct", "XLOG_BLCKSZ");`
`4023`	`4023`	`result = false;`
`4024`	`4024`	`}`
`4025`	`4025`	`#endif`
`4026`	`4026`	`#if BLCKSZ < PG_IO_ALIGN_SIZE`
`4027`	`4027`	`if (result && (flags & IO_DIRECT_DATA))`
`4028`	`4028`	`{`
`4029`		`- GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small",`
	`4029`	`+ GUC_check_errdetail("\"%s\" is not supported for WAL because %s is too small.",`
`4030`	`4030`	`"debug_io_direct", "BLCKSZ");`
`4031`	`4031`	`result = false;`
`4032`	`4032`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2183,7 +2183,7 @@ check_backtrace_functions(char newval, void extra, GucSource source)`
`2183`	`2183`	`", \n\t");`
`2184`	`2184`	`if (validlen != newvallen)`
`2185`	`2185`	`{`
`2186`		`- GUC_check_errdetail("Invalid character");`
	`2186`	`+ GUC_check_errdetail("Invalid character.");`
`2187`	`2187`	`return false;`
`2188`	`2188`	`}`
`2189`	`2189`