Use memmove() instead of memcpy() for copying overlapping regions.

hlinnaka · hlinnaka · commit 6c2744f1d3a0 · 2014-02-10T09:57:59.000+02:00
In commit d2495f2, I fixed this bug in to_tsquery(), but missed the fact that plainto_tsquery() has the same bug.
diff --git a/src/backend/tsearch/to_tsany.c b/src/backend/tsearch/to_tsany.c
@@ -396,6 +396,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)
 	if (query->size == 0)
 		PG_RETURN_TSQUERY(query);
 
+	/* clean out any stopword placeholders from the tree */
 	res = clean_fakeval(GETQUERY(query), &len);
 	if (!res)
 	{
@@ -405,6 +406,10 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)
 	}
 	memcpy((void *) GETQUERY(query), (void *) res, len * sizeof(QueryItem));
 
+	/*
+	 * Removing the stopword placeholders might've resulted in fewer
+	 * QueryItems. If so, move the operands up accordingly.
+	 */
 	if (len != query->size)
 	{
 		char	   *oldoperand = GETOPERAND(query);
@@ -413,7 +418,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)
 		Assert(len < query->size);
 
 		query->size = len;
-		memcpy((void *) GETOPERAND(query), oldoperand, lenoperand);
+		memmove((void *) GETOPERAND(query), oldoperand, lenoperand);
 		SET_VARSIZE(query, COMPUTESIZE(len, lenoperand));
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -396,6 +396,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)`
`396`	`396`	`if (query->size == 0)`
`397`	`397`	`PG_RETURN_TSQUERY(query);`
`398`	`398`
	`399`	`+ /* clean out any stopword placeholders from the tree */`
`399`	`400`	`res = clean_fakeval(GETQUERY(query), &len);`
`400`	`401`	`if (!res)`
`401`	`402`	`{`
`@@ -405,6 +406,10 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)`
`405`	`406`	`}`
`406`	`407`	`memcpy((void ) GETQUERY(query), (void ) res, len * sizeof(QueryItem));`
`407`	`408`
	`409`	`+ /*`
	`410`	`+ * Removing the stopword placeholders might've resulted in fewer`
	`411`	`+ * QueryItems. If so, move the operands up accordingly.`
	`412`	`+ */`
`408`	`413`	`if (len != query->size)`
`409`	`414`	`{`
`410`	`415`	`char *oldoperand = GETOPERAND(query);`
`@@ -413,7 +418,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)`
`413`	`418`	`Assert(len < query->size);`
`414`	`419`
`415`	`420`	`query->size = len;`
`416`		`- memcpy((void *) GETOPERAND(query), oldoperand, lenoperand);`
	`421`	`+ memmove((void *) GETOPERAND(query), oldoperand, lenoperand);`
`417`	`422`	`SET_VARSIZE(query, COMPUTESIZE(len, lenoperand));`
`418`	`423`	`}`
`419`	`424`