Use usleep instead of select for timeouts in PostgresNode.pm

adunstan · adunstan · commit 6c6970a280a5 · 2017-07-17T15:22:37.000-04:00
select() for pure timeouts is not portable, and in particular doesn't work on Windows. Discussion: https://postgr.es/m/186943e0-3405-978d-b19d-9d3335427c86@2ndQuadrant.com
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
@@ -93,6 +93,7 @@ use RecursiveCopy;
 use Socket;
 use Test::More;
 use TestLib ();
+use Time::HiRes qw(usleep);
 use Scalar::Util qw(blessed);
 
 our @EXPORT = qw(
@@ -1248,7 +1249,7 @@ sub poll_query_until
 		}
 
 		# Wait 0.1 second before retrying.
-		select undef, undef, undef, 0.1;
+		usleep(100000);
 
 		$attempts++;
 	}

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ use RecursiveCopy;`
`93`	`93`	`use Socket;`
`94`	`94`	`use Test::More;`
`95`	`95`	`use TestLib ();`
	`96`	`+use Time::HiRes qw(usleep);`
`96`	`97`	`use Scalar::Util qw(blessed);`
`97`	`98`
`98`	`99`	`our @EXPORT = qw(`
`@@ -1248,7 +1249,7 @@ sub poll_query_until`
`1248`	`1249`	`}`
`1249`	`1250`
`1250`	`1251`	`# Wait 0.1 second before retrying.`
`1251`		`- select undef, undef, undef, 0.1;`
	`1252`	`+ usleep(100000);`
`1252`	`1253`
`1253`	`1254`	`$attempts++;`
`1254`	`1255`	`}`