Update C comments to mention SQL:2003 handling of power return values.

bmomjian · bmomjian · commit 6e3e60095dd4 · 2008-05-09T15:36:06.000Z
diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.155 2008/04/21 00:26:45 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.156 2008/05/09 15:36:06 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1331,7 +1331,8 @@ dpow(PG_FUNCTION_ARGS)
 
 	/*
 	 * The SQL spec requires that we emit a particular SQLSTATE error code for
-	 * certain error conditions.
+	 * certain error conditions.  Specifically, we don't return a divide-by-zero
+	 * error code for 0 ^ -1.
 	 */
 	if ((arg1 == 0 && arg2 < 0) ||
 		(arg1 < 0 && floor(arg2) != arg2))
diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c
@@ -14,7 +14,7 @@
  * Copyright (c) 1998-2008, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.112 2008/05/08 22:17:54 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.113 2008/05/09 15:36:06 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1893,8 +1893,9 @@ numeric_power(PG_FUNCTION_ARGS)
 	trunc_var(&arg2_trunc, 0);
 
 	/*
-	 * Return special SQLSTATE error codes for a few conditions mandated by
-	 * the standard.
+	 * The SQL spec requires that we emit a particular SQLSTATE error code for
+	 * certain error conditions.  Specifically, we don't return a divide-by-zero
+	 * error code for 0 ^ -1.
 	 */
 	if ((cmp_var(&arg1, &const_zero) == 0 &&
 		 cmp_var(&arg2, &const_zero) < 0) ||
@@ -5283,6 +5284,7 @@ power_var_int(NumericVar *base, int exp, NumericVar *result, int rscale)
 			/*
 			 *	While 0 ^ 0 can be either 1 or indeterminate (error), we
 			 *	treat it as 1 because most programming languages do this.
+			 *	SQL:2003 also requires a return value of 1.
 			 *	http://en.wikipedia.org/wiki/Exponentiation#Zero_to_the_zero_power
 			 */
 			set_var_from_var(&const_one, result);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.155 2008/04/21 00:26:45 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.156 2008/05/09 15:36:06 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1331,7 +1331,8 @@ dpow(PG_FUNCTION_ARGS)`
`1331`	`1331`
`1332`	`1332`	`/*`
`1333`	`1333`	`* The SQL spec requires that we emit a particular SQLSTATE error code for`
`1334`		`- * certain error conditions.`
	`1334`	`+ * certain error conditions. Specifically, we don't return a divide-by-zero`
	`1335`	`+ * error code for 0 ^ -1.`
`1335`	`1336`	`*/`
`1336`	`1337`	`if ((arg1 == 0 && arg2 < 0) \|\|`
`1337`	`1338`	`(arg1 < 0 && floor(arg2) != arg2))`