Arrange to call localtime() during postmaster startup. On most Unixen,

tglsfdc · tglsfdc · commit 6e546c286c92 · 2002-02-19T19:53:35.000Z
the first call of localtime() in a process will read /usr/lib/tztab or
local equivalent.  Better to do this once in the postmaster and inherit
the data by fork() than to have to do it during every backend start.
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.264 2002/01/10 01:11:45 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.265 2002/02/19 19:53:35 tgl Exp $
  *
  * NOTES
  *
@@ -723,6 +723,10 @@ PostmasterMain(int argc, char *argv[])
 
 	/*
 	 * Set up signal handlers for the postmaster process.
+	 *
+	 * CAUTION: when changing this list, check for side-effects on the
+	 * signal handling setup of child processes.  See tcop/postgres.c,
+	 * bootstrap/bootstrap.c, and postmaster/pgstat.c.
 	 */
 	pqinitmask();
 	PG_SETMASK(&BlockSig);
@@ -749,6 +753,18 @@ PostmasterMain(int argc, char *argv[])
 	 */
 	whereToSendOutput = None;
 
+	/*
+	 * On many platforms, the first call of localtime() incurs significant
+	 * overhead to load timezone info from the system configuration files.
+	 * By doing it once in the postmaster, we avoid having to do it in every
+	 * started child process.  The savings are not huge, but they add up...
+	 */
+	{
+		time_t		now = time(NULL);
+
+		(void) localtime(&now);
+	}
+
 	/*
 	 * Initialize and startup the statistics collector process
 	 */
@@ -1793,15 +1809,14 @@ SignalChildren(int signal)
 	Dlelem	   *curr,
 			   *next;
 	Backend    *bp;
-	int			mypid = getpid();
 
 	curr = DLGetHead(BackendList);
 	while (curr)
 	{
 		next = DLGetSucc(curr);
 		bp = (Backend *) DLE_VAL(curr);
 
-		if (bp->pid != mypid)
+		if (bp->pid != MyProcPid)
 		{
 			if (DebugLvl >= 1)
 				elog(DEBUG, "SignalChildren: sending signal %d to process %d",
@@ -2412,13 +2427,12 @@ CountChildren(void)
 {
 	Dlelem	   *curr;
 	Backend    *bp;
-	int			mypid = getpid();
 	int			cnt = 0;
 
 	for (curr = DLGetHead(BackendList); curr; curr = DLGetSucc(curr))
 	{
 		bp = (Backend *) DLE_VAL(curr);
-		if (bp->pid != mypid)
+		if (bp->pid != MyProcPid)
 			cnt++;
 	}
 	if (CheckPointPID != 0)
