Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().

tglsfdc · tglsfdc · commit 6e5d9f278c12 · 2015-08-21T20:32:11.000-04:00
For no obvious reason, spi_printtup() was coded to enlarge the tuple
pointer table by just 256 slots at a time, rather than doubling the size at
each reallocation, as is our usual habit.  For very large SPI results, this
makes for O(N^2) time spent in repalloc(), which of course soon comes to
dominate the runtime.  Use the standard doubling approach instead.

This is a longstanding performance bug, so back-patch to all active
branches.

Neil Conway
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
@@ -1797,7 +1797,8 @@ spi_printtup(TupleTableSlot *slot, DestReceiver *self)
 
 	if (tuptable->free == 0)
 	{
-		tuptable->free = 256;
+		/* Double the size of the pointer array */
+		tuptable->free = tuptable->alloced;
 		tuptable->alloced += tuptable->free;
 		tuptable->vals = (HeapTuple *) repalloc(tuptable->vals,
 									  tuptable->alloced * sizeof(HeapTuple));

Original file line number	Diff line number	Diff line change
`@@ -1797,7 +1797,8 @@ spi_printtup(TupleTableSlot slot, DestReceiver self)`
`1797`	`1797`
`1798`	`1798`	`if (tuptable->free == 0)`
`1799`	`1799`	`{`
`1800`		`- tuptable->free = 256;`
	`1800`	`+ /* Double the size of the pointer array */`
	`1801`	`+ tuptable->free = tuptable->alloced;`
`1801`	`1802`	`tuptable->alloced += tuptable->free;`
`1802`	`1803`	`tuptable->vals = (HeapTuple *) repalloc(tuptable->vals,`
`1803`	`1804`	`tuptable->alloced * sizeof(HeapTuple));`