COPY: Add an assertion

petere · petere · commit 6f018c6dda20 · 2012-03-14T22:44:40.000+02:00
This is for tools such as Coverity that don't know that the grammar
enforces that the case of not having a relation (but instead a query)
cannot happen in the FROM case.
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
@@ -797,6 +797,8 @@ DoCopy(const CopyStmt *stmt, const char *queryString)
 
 	if (is_from)
 	{
+		Assert(rel);
+
 		/* check read-only transaction */
 		if (XactReadOnly && rel->rd_backend != MyBackendId)
 			PreventCommandIfReadOnly("COPY FROM");

Original file line number	Diff line number	Diff line change
`@@ -797,6 +797,8 @@ DoCopy(const CopyStmt stmt, const char queryString)`
`797`	`797`
`798`	`798`	`if (is_from)`
`799`	`799`	`{`
	`800`	`+ Assert(rel);`
	`801`	`+`
`800`	`802`	`/* check read-only transaction */`
`801`	`803`	`if (XactReadOnly && rel->rd_backend != MyBackendId)`
`802`	`804`	`PreventCommandIfReadOnly("COPY FROM");`