Silence a gcc compiler warning about non-literal format string with no args

hlinnaka · hlinnaka · commit 7340793f31f3 · 2009-05-20T08:48:10.000Z
when compiling with -Wformat-security. Fujii Masao.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.284 2009/05/12 03:11:01 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.285 2009/05/20 08:48:10 heikki Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -606,7 +606,7 @@ DropErrorMsgWrongType(const char *relname, char wrongkind, char rightkind)
 	ereport(ERROR,
 			(errcode(ERRCODE_WRONG_OBJECT_TYPE),
 			 errmsg(rentry->nota_msg, relname),
-			 (wentry->kind != '\0') ? errhint(wentry->drophint_msg) : 0));
+			 (wentry->kind != '\0') ? errhint("%s", _(wentry->drophint_msg)) : 0));
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.284 2009/05/12 03:11:01 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.285 2009/05/20 08:48:10 heikki Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -606,7 +606,7 @@ DropErrorMsgWrongType(const char *relname, char wrongkind, char rightkind)`
`606`	`606`	`ereport(ERROR,`
`607`	`607`	`(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
`608`	`608`	`errmsg(rentry->nota_msg, relname),`
`609`		`- (wentry->kind != '\0') ? errhint(wentry->drophint_msg) : 0));`
	`609`	`+ (wentry->kind != '\0') ? errhint("%s", _(wentry->drophint_msg)) : 0));`
`610`	`610`	`}`
`611`	`611`
`612`	`612`	`/*`