pg_dump: fix double free of query results

alvherre · alvherre · commit 77503a7638a3 · 2012-03-19T17:55:51.000-03:00
This bug was introduced while refactoring in commit 1631598 --- no need to back-patch. Bug report and fix from Joachim Wieland.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -2372,8 +2372,6 @@ dumpBlobs(Archive *fout, void *arg)
 		PQclear(res);
 	} while (ntups > 0);
 
-	PQclear(res);
-
 	return 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2372,8 +2372,6 @@ dumpBlobs(Archive fout, void arg)`
`2372`	`2372`	`PQclear(res);`
`2373`	`2373`	`} while (ntups > 0);`
`2374`	`2374`
`2375`		`- PQclear(res);`
`2376`		`-`
`2377`	`2375`	`return 1;`
`2378`	`2376`	`}`
`2379`	`2377`