Avoid accidental wildcard expansion in msys shell

adunstan · adunstan · commit 78b408a20a5a · 2019-03-03T11:48:12.000-05:00
Commit f092de0 added a test for pg_dumpall --exclude-database including the wildcard pattern '*dump*' which matches some files in the source directory. The test library on msys uses the shell which expands this and thus the program gets incorrect arguments. This doesn't happen if the pattern doesn't match any files, so here the pattern is set to '*dump_test*' which is such a pattern. Per buildfarm animal jacana.
diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
@@ -227,7 +227,7 @@
 	pg_dumpall_exclude => {
 		dump_cmd => [
 			'pg_dumpall', '-v', "--file=$tempdir/pg_dumpall_exclude.sql",
-			'--exclude-database', '*dump*', '--no-sync',
+			'--exclude-database', '*dump_test*', '--no-sync',
 		],
 	},
 	no_blobs => {
