Minor tweak to avoid unnecessary memory bloat when dumping extremely wide

tglsfdc · tglsfdc · commit 7969649bd522 · 2005-01-26T21:24:12.000Z
column values in -d mode.  Per report from Marty Scholes.  This doesn't
completely solve the issue, because we still need multiple copies of the
field value, but at least one copy can be got rid of painlessly ...
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.401 2005/01/23 00:30:26 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.402 2005/01/26 21:24:12 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -985,7 +985,7 @@ dumpTableData_insert(Archive *fout, void *dcontext)
 					appendPQExpBuffer(q, fmtId(PQfname(res, field)));
 				}
 				appendPQExpBuffer(q, ") ");
-				archprintf(fout, "%s", q->data);
+				archputs(q->data, fout);
 			}
 			archprintf(fout, "VALUES (");
 			for (field = 0; field < nfields; field++)
@@ -1047,7 +1047,7 @@ dumpTableData_insert(Archive *fout, void *dcontext)
 						/* All other types are printed as string literals. */
 						resetPQExpBuffer(q);
 						appendStringLiteral(q, PQgetvalue(res, tuple, field), false);
-						archprintf(fout, "%s", q->data);
+						archputs(q->data, fout);
 						break;
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`* by PostgreSQL`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.401 2005/01/23 00:30:26 tgl Exp $`
	`15`	`+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.402 2005/01/26 21:24:12 tgl Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -985,7 +985,7 @@ dumpTableData_insert(Archive fout, void dcontext)`
`985`	`985`	`appendPQExpBuffer(q, fmtId(PQfname(res, field)));`
`986`	`986`	`}`
`987`	`987`	`appendPQExpBuffer(q, ") ");`
`988`		`- archprintf(fout, "%s", q->data);`
	`988`	`+ archputs(q->data, fout);`
`989`	`989`	`}`
`990`	`990`	`archprintf(fout, "VALUES (");`
`991`	`991`	`for (field = 0; field < nfields; field++)`
`@@ -1047,7 +1047,7 @@ dumpTableData_insert(Archive fout, void dcontext)`
`1047`	`1047`	`/* All other types are printed as string literals. */`
`1048`	`1048`	`resetPQExpBuffer(q);`
`1049`	`1049`	`appendStringLiteral(q, PQgetvalue(res, tuple, field), false);`
`1050`		`- archprintf(fout, "%s", q->data);`
	`1050`	`+ archputs(q->data, fout);`
`1051`	`1051`	`break;`
`1052`	`1052`	`}`
`1053`	`1053`	`}`