Named restore point improvements.

robertmhaas · robertmhaas · commit 79ad8fc5f857 · 2011-02-24T19:02:00.000-05:00
Emit a log message when creating a named restore point, and improve
documentation for pg_create_restore_point().

Euler Taveira de Oliveira, 	per suggestions from Thom Brown, with some
additional wordsmithing by me.
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
@@ -14069,6 +14069,16 @@ postgres=# select pg_start_backup('label_goes_here');
     of the transaction log file currently in use.
    </para>
 
+   <para>
+    <function>pg_create_restore_point</> creates a named transaction log
+    record that can be used as recovery target, and returns the corresponding
+    transaction log location.  The given name can then be used with
+    <xref linkend="recovery-target-name"> to specify the point up to which
+    recovery will proceed.  Avoid creating multiple restore points with the
+    same name, since recovery will stop at the first one whose name matches
+    the recovery target.
+   </para>
+
    <para>
     <function>pg_current_xlog_location</> displays the current transaction log write
     location in the same format used by the above functions.  Similarly,
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -8144,6 +8144,10 @@ XLogRestorePoint(const char *rpName)
 
 	RecPtr = XLogInsert(RM_XLOG_ID, XLOG_RESTORE_POINT, &rdata);
 
+	ereport(LOG,
+			(errmsg("restore point \"%s\" created at %X/%X",
+					rpName,	RecPtr.xlogid, RecPtr.xrecoff)));
+
 	return RecPtr;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8144,6 +8144,10 @@ XLogRestorePoint(const char *rpName)`
`8144`	`8144`
`8145`	`8145`	`RecPtr = XLogInsert(RM_XLOG_ID, XLOG_RESTORE_POINT, &rdata);`
`8146`	`8146`
	`8147`	`+ ereport(LOG,`
	`8148`	`+ (errmsg("restore point \"%s\" created at %X/%X",`
	`8149`	`+ rpName, RecPtr.xlogid, RecPtr.xrecoff)));`
	`8150`	`+`
`8147`	`8151`	`return RecPtr;`
`8148`	`8152`	`}`
`8149`	`8153`