Avoid null pointer dereference if error result lacks SQLSTATE.

tglsfdc · tglsfdc · commit 7d72fd9e6db6 · 2020-11-01T11:26:31.000-05:00
Although error results received from the backend should always have a SQLSTATE field, ones generated by libpq won't, making this code vulnerable to a crash after, say, untimely loss of connection. Noted by Coverity. Oversight in commit 403a3d9. Back-patch to 9.5, as that was.
diff --git a/src/bin/pg_dump/pg_backup_db.c b/src/bin/pg_dump/pg_backup_db.c
@@ -543,9 +543,9 @@ bool
 IsLockTableGeneric(Archive *AHX)
 {
 	ArchiveHandle *AH = (ArchiveHandle *) AHX;
-	PGresult *res;
-	char	 *sqlstate;
-	bool	retval;
+	PGresult   *res;
+	char	   *sqlstate;
+	bool		retval;
 
 	if (AHX->remoteVersion >= 140000)
 		return true;
@@ -572,13 +572,15 @@ IsLockTableGeneric(Archive *AHX)
 			break;
 		case PGRES_FATAL_ERROR:
 			sqlstate = PQresultErrorField(res, PG_DIAG_SQLSTATE);
-			if (strcmp(sqlstate, ERRCODE_WRONG_OBJECT_TYPE) == 0)
+			if (sqlstate &&
+				strcmp(sqlstate, ERRCODE_WRONG_OBJECT_TYPE) == 0)
 			{
 				retval = false;
 				break;
 			}
-			else if (strcmp(sqlstate, ERRCODE_LOCK_NOT_AVAILABLE) == 0 ||
-					 strcmp(sqlstate, ERRCODE_INSUFFICIENT_PRIVILEGE) == 0)
+			else if (sqlstate &&
+					 (strcmp(sqlstate, ERRCODE_LOCK_NOT_AVAILABLE) == 0 ||
+					  strcmp(sqlstate, ERRCODE_INSUFFICIENT_PRIVILEGE) == 0))
 			{
 				retval = true;
 				break;
