Fix pointer-arithmetic thinko in pg_stat_ssl patch.

tglsfdc · tglsfdc · commit 7d791ed49be2 · 2015-07-27T15:58:46.000-04:00
Nasty memory-stomp bug in commit 9029f4b. It's not apparent how this survived even cursory testing :-(. Per report from Peter Holzer.
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c
@@ -3024,7 +3024,7 @@ pgstat_read_current_status(void)
 			localappname += NAMEDATALEN;
 			localactivity += pgstat_track_activity_query_size;
 #ifdef USE_SSL
-			localsslstatus += sizeof(PgBackendSSLStatus);
+			localsslstatus++;
 #endif
 			localNumBackends++;
 		}

Original file line number	Diff line number	Diff line change
`@@ -3024,7 +3024,7 @@ pgstat_read_current_status(void)`
`3024`	`3024`	`localappname += NAMEDATALEN;`
`3025`	`3025`	`localactivity += pgstat_track_activity_query_size;`
`3026`	`3026`	`#ifdef USE_SSL`
`3027`		`- localsslstatus += sizeof(PgBackendSSLStatus);`
	`3027`	`+ localsslstatus++;`
`3028`	`3028`	`#endif`
`3029`	`3029`	`localNumBackends++;`
`3030`	`3030`	`}`