Fix incorrect source filename references

david-rowley · david-rowley · commit 7ec4b9ff80d9 · 2024-12-23T19:41:49.000+13:00
Jian He reported the src/include/utility/tcop.h one and the remainder were found by using a script to look for src/* and check that we have a filename or directory of that name. In passing, fix some out-date comments. Reported-by: Jian He <jian.universality@gmail.com> Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CACJufxGoE3H-7VgO02=PrR4SNuVWDVbfTyUnwO0HvS-Lxurnog@mail.gmail.com
diff --git a/src/backend/commands/aggregatecmds.c b/src/backend/commands/aggregatecmds.c
@@ -12,11 +12,11 @@
  *	  src/backend/commands/aggregatecmds.c
  *
  * DESCRIPTION
- *	  The "DefineFoo" routines take the parse tree and pick out the
+ *	  The "DefineAggregate" routine takes the parse tree and picks out the
  *	  appropriate arguments/flags, passing the results to the
- *	  corresponding "FooDefine" routines (in src/catalog) that do
- *	  the actual catalog-munging.  These routines also verify permission
- *	  of the user to execute the command.
+ *	  "AggregateCreate" routine (in src/backend/catalog), which does the
+ *	  actual catalog-munging.  DefineAggregate also verifies the permission of
+ *	  the user to execute the command.
  *
  *-------------------------------------------------------------------------
  */
diff --git a/src/backend/commands/define.c b/src/backend/commands/define.c
@@ -12,20 +12,7 @@
  *	  src/backend/commands/define.c
  *
  * DESCRIPTION
- *	  The "DefineFoo" routines take the parse tree and pick out the
- *	  appropriate arguments/flags, passing the results to the
- *	  corresponding "FooDefine" routines (in src/catalog) that do
- *	  the actual catalog-munging.  These routines also verify permission
- *	  of the user to execute the command.
- *
- * NOTES
- *	  These things must be defined and committed in the following order:
- *		"create function":
- *				input/output, recv/send procedures
- *		"create type":
- *				type
- *		"create operator":
- *				operators
+ *	  Support routines for dealing with DefElem nodes.
  *
  *
  *-------------------------------------------------------------------------
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
@@ -15,7 +15,7 @@
  * DESCRIPTION
  *	  These routines take the parse tree and pick out the
  *	  appropriate arguments/flags, and pass the results to the
- *	  corresponding "FooDefine" routines (in src/catalog) that do
+ *	  corresponding "FooCreate" routines (in src/backend/catalog) that do
  *	  the actual catalog-munging.  These routines also verify permission
  *	  of the user to execute the command.
  *
diff --git a/src/backend/commands/operatorcmds.c b/src/backend/commands/operatorcmds.c
@@ -14,7 +14,7 @@
  * DESCRIPTION
  *	  The "DefineFoo" routines take the parse tree and pick out the
  *	  appropriate arguments/flags, passing the results to the
- *	  corresponding "FooDefine" routines (in src/catalog) that do
+ *	  corresponding "FooCreate" routines (in src/backend/catalog) that do
  *	  the actual catalog-munging.  These routines also verify permission
  *	  of the user to execute the command.
  *
diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c
@@ -13,7 +13,7 @@
  * DESCRIPTION
  *	  The "DefineFoo" routines take the parse tree and pick out the
  *	  appropriate arguments/flags, passing the results to the
- *	  corresponding "FooDefine" routines (in src/catalog) that do
+ *	  corresponding "FooCreate" routines (in src/backend/catalog) that do
  *	  the actual catalog-munging.  These routines also verify permission
  *	  of the user to execute the command.
  *
diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
@@ -122,7 +122,7 @@ CommandIsReadOnly(PlannedStmt *pstmt)
 /*
  * Determine the degree to which a utility command is read only.
  *
- * Note the definitions of the relevant flags in src/include/utility/tcop.h.
+ * Note the definitions of the relevant flags in src/include/tcop/utility.h.
  */
 static int
 ClassifyUtilityCommandAsReadOnly(Node *parsetree)
diff --git a/src/backend/utils/misc/guc_internal.h b/src/backend/utils/misc/guc_internal.h
@@ -6,7 +6,7 @@
  *
  * Copyright (c) 2000-2024, PostgreSQL Global Development Group
  *
- * src/include/utils/guc_internal.h
+ * src/backend/utils/misc/guc_internal.h
  *--------------------------------------------------------------------
  */
 #ifndef GUC_INTERNAL_H
diff --git a/src/fe_utils/astreamer_file.c b/src/fe_utils/astreamer_file.c
@@ -9,7 +9,7 @@
  * Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *		  src/bin/pg_basebackup/astreamer_file.c
+ *		  src/fe_utils/astreamer_file.c
  *-------------------------------------------------------------------------
  */
 
diff --git a/src/fe_utils/astreamer_gzip.c b/src/fe_utils/astreamer_gzip.c
@@ -20,7 +20,7 @@
  * Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *		  src/bin/pg_basebackup/astreamer_gzip.c
+ *		  src/fe_utils/astreamer_gzip.c
  *-------------------------------------------------------------------------
  */
 
diff --git a/src/fe_utils/astreamer_lz4.c b/src/fe_utils/astreamer_lz4.c
@@ -9,7 +9,7 @@
  * Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *		  src/bin/pg_basebackup/astreamer_lz4.c
+ *		  src/fe_utils/astreamer_lz4.c
  *-------------------------------------------------------------------------
  */
 
diff --git a/src/fe_utils/astreamer_tar.c b/src/fe_utils/astreamer_tar.c
@@ -15,7 +15,7 @@
  * Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *		  src/bin/pg_basebackup/astreamer_tar.c
+ *		  src/fe_utils/astreamer_tar.c
  *-------------------------------------------------------------------------
  */
 
diff --git a/src/fe_utils/astreamer_zstd.c b/src/fe_utils/astreamer_zstd.c
@@ -9,7 +9,7 @@
  * Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *		  src/bin/pg_basebackup/astreamer_zstd.c
+ *		  src/fe_utils/astreamer_zstd.c
  *-------------------------------------------------------------------------
  */
 
diff --git a/src/include/fe_utils/astreamer.h b/src/include/fe_utils/astreamer.h
@@ -24,7 +24,7 @@
  * Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *		  src/bin/pg_basebackup/astreamer.h
+ *		  src/include/fe_utils/astreamer.h
  *-------------------------------------------------------------------------
  */
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`* DESCRIPTION`
`16`	`16`	`* These routines take the parse tree and pick out the`
`17`	`17`	`* appropriate arguments/flags, and pass the results to the`
`18`		`- * corresponding "FooDefine" routines (in src/catalog) that do`
	`18`	`+ * corresponding "FooCreate" routines (in src/backend/catalog) that do`
`19`	`19`	`* the actual catalog-munging. These routines also verify permission`
`20`	`20`	`* of the user to execute the command.`
`21`	`21`	`*`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`* DESCRIPTION`
`15`	`15`	`* The "DefineFoo" routines take the parse tree and pick out the`
`16`	`16`	`* appropriate arguments/flags, passing the results to the`
`17`		`- * corresponding "FooDefine" routines (in src/catalog) that do`
	`17`	`+ * corresponding "FooCreate" routines (in src/backend/catalog) that do`
`18`	`18`	`* the actual catalog-munging. These routines also verify permission`
`19`	`19`	`* of the user to execute the command.`
`20`	`20`	`*`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`* DESCRIPTION`
`14`	`14`	`* The "DefineFoo" routines take the parse tree and pick out the`
`15`	`15`	`* appropriate arguments/flags, passing the results to the`
`16`		`- * corresponding "FooDefine" routines (in src/catalog) that do`
	`16`	`+ * corresponding "FooCreate" routines (in src/backend/catalog) that do`
`17`	`17`	`* the actual catalog-munging. These routines also verify permission`
`18`	`18`	`* of the user to execute the command.`
`19`	`19`	`*`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ CommandIsReadOnly(PlannedStmt *pstmt)`
`122`	`122`	`/*`
`123`	`123`	`* Determine the degree to which a utility command is read only.`
`124`	`124`	`*`
`125`		`- * Note the definitions of the relevant flags in src/include/utility/tcop.h.`
	`125`	`+ * Note the definitions of the relevant flags in src/include/tcop/utility.h.`
`126`	`126`	`*/`
`127`	`127`	`static int`
`128`	`128`	`ClassifyUtilityCommandAsReadOnly(Node *parsetree)`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`*`
`7`	`7`	`* Copyright (c) 2000-2024, PostgreSQL Global Development Group`
`8`	`8`	`*`
`9`		`- * src/include/utils/guc_internal.h`
	`9`	`+ * src/backend/utils/misc/guc_internal.h`
`10`	`10`	`*--------------------------------------------------------------------`
`11`	`11`	`*/`
`12`	`12`	`#ifndef GUC_INTERNAL_H`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`* Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * src/bin/pg_basebackup/astreamer_file.c`
	`12`	`+ * src/fe_utils/astreamer_file.c`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`* Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group`
`21`	`21`	`*`
`22`	`22`	`* IDENTIFICATION`
`23`		`- * src/bin/pg_basebackup/astreamer_gzip.c`
	`23`	`+ * src/fe_utils/astreamer_gzip.c`
`24`	`24`	`*-------------------------------------------------------------------------`
`25`	`25`	`*/`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`* Portions Copyright (c) 1996-2024, PostgreSQL Global Development Group`
`25`	`25`	`*`
`26`	`26`	`* IDENTIFICATION`
`27`		`- * src/bin/pg_basebackup/astreamer.h`
	`27`	`+ * src/include/fe_utils/astreamer.h`
`28`	`28`	`*-------------------------------------------------------------------------`
`29`	`29`	`*/`
`30`	`30`