Shave a few cycles in string_agg().

robertmhaas · robertmhaas · commit 7f0e4bb82e40 · 2011-12-21T08:53:50.000-05:00
Pavel Stehule
diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
@@ -3621,7 +3621,7 @@ string_agg_finalfn(PG_FUNCTION_ARGS)
 	state = PG_ARGISNULL(0) ? NULL : (StringInfo) PG_GETARG_POINTER(0);
 
 	if (state != NULL)
-		PG_RETURN_TEXT_P(cstring_to_text(state->data));
+		PG_RETURN_TEXT_P(cstring_to_text_with_len(state->data, state->len));
 	else
 		PG_RETURN_NULL();
 }

Original file line number	Diff line number	Diff line change
`@@ -3621,7 +3621,7 @@ string_agg_finalfn(PG_FUNCTION_ARGS)`
`3621`	`3621`	`state = PG_ARGISNULL(0) ? NULL : (StringInfo) PG_GETARG_POINTER(0);`
`3622`	`3622`
`3623`	`3623`	`if (state != NULL)`
`3624`		`- PG_RETURN_TEXT_P(cstring_to_text(state->data));`
	`3624`	`+ PG_RETURN_TEXT_P(cstring_to_text_with_len(state->data, state->len));`
`3625`	`3625`	`else`
`3626`	`3626`	`PG_RETURN_NULL();`
`3627`	`3627`	`}`