Modify the new to_timestamp implementation so that end-of-format-string

hlinnaka · hlinnaka · commit 7fb27531e8f5 · 2008-12-01T17:11:18.000Z
is treated like a non-digit separator. This fixes the inconsistency in
examples like:

to_timestamp('2008-01-2', 'YYYY-MM-DD') -- didn't work

and

to_timestamp('2008-1-02', 'YYYY-MM-DD') -- did work
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.150 2008/11/10 17:36:53 heikki Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.151 2008/12/01 17:11:18 heikki Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2008, PostgreSQL Global Development Group
@@ -1678,8 +1678,9 @@ is_next_separator(FormatNode *n)
 	 */
 	n++;
 
+	/* end of format string is treated like a non-digit separator */
 	if (n->type == NODE_TYPE_END)
-		return FALSE;
+		return TRUE;
 
 	if (n->type == NODE_TYPE_ACTION)
 	{

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.150 2008/11/10 17:36:53 heikki Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.151 2008/12/01 17:11:18 heikki Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2008, PostgreSQL Global Development Group`
`@@ -1678,8 +1678,9 @@ is_next_separator(FormatNode *n)`
`1678`	`1678`	`*/`
`1679`	`1679`	`n++;`
`1680`	`1680`
	`1681`	`+ /* end of format string is treated like a non-digit separator */`
`1681`	`1682`	`if (n->type == NODE_TYPE_END)`
`1682`		`- return FALSE;`
	`1683`	`+ return TRUE;`
`1683`	`1684`
`1684`	`1685`	`if (n->type == NODE_TYPE_ACTION)`
`1685`	`1686`	`{`