Make amcanorder independent of amconsistentordering

petere · petere · commit 8021c77769e9 · 2025-03-08T09:37:06.000+01:00
Follow-up to commit af4002b: Make amconsistentordering not depend on amcanorder. Although they are related, they are independent properties. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/E1tngY6-0000UL-2n%40gemulon.postgresql.org
diff --git a/src/backend/utils/cache/lsyscache.c b/src/backend/utils/cache/lsyscache.c
@@ -750,7 +750,7 @@ equality_ops_are_compatible(Oid opno1, Oid opno2)
  * they belong to the same family.)
  *
  * (This is identical to equality_ops_are_compatible(), except that we check
- * amcanorder plus amconsistentordering instead of amconsistentequality.)
+ * amconsistentordering instead of amconsistentequality.)
  */
 bool
 comparison_ops_are_compatible(Oid opno1, Oid opno2)
@@ -782,7 +782,7 @@ comparison_ops_are_compatible(Oid opno1, Oid opno2)
 		{
 			IndexAmRoutine *amroutine = GetIndexAmRoutineByAmId(op_form->amopmethod, false);
 
-			if (amroutine->amcanorder && amroutine->amconsistentordering)
+			if (amroutine->amconsistentordering)
 			{
 				result = true;
 				break;

Original file line number	Diff line number	Diff line change
`@@ -750,7 +750,7 @@ equality_ops_are_compatible(Oid opno1, Oid opno2)`
`750`	`750`	`* they belong to the same family.)`
`751`	`751`	`*`
`752`	`752`	`* (This is identical to equality_ops_are_compatible(), except that we check`
`753`		`- * amcanorder plus amconsistentordering instead of amconsistentequality.)`
	`753`	`+ * amconsistentordering instead of amconsistentequality.)`
`754`	`754`	`*/`
`755`	`755`	`bool`
`756`	`756`	`comparison_ops_are_compatible(Oid opno1, Oid opno2)`
`@@ -782,7 +782,7 @@ comparison_ops_are_compatible(Oid opno1, Oid opno2)`
`782`	`782`	`{`
`783`	`783`	`IndexAmRoutine *amroutine = GetIndexAmRoutineByAmId(op_form->amopmethod, false);`
`784`	`784`
`785`		`- if (amroutine->amcanorder && amroutine->amconsistentordering)`
	`785`	`+ if (amroutine->amconsistentordering)`
`786`	`786`	`{`
`787`	`787`	`result = true;`
`788`	`788`	`break;`