Don't pass oidvector by value.

nmisch · nmisch · commit 813895e4acfa · 2013-06-12T19:50:37.000-04:00
Since the structure ends with a flexible array, doing so truncates any
vector having more than one element.  New in 9.3, so no back-patch.
diff --git a/src/backend/commands/alter.c b/src/backend/commands/alter.c
@@ -231,7 +231,7 @@ AlterObjectRename_internal(Relation rel, Oid objectId, const char *new_name)
 		Form_pg_proc proc = (Form_pg_proc) GETSTRUCT(oldtup);
 
 		IsThereFunctionInNamespace(new_name, proc->pronargs,
-								   proc->proargtypes, proc->pronamespace);
+								   &proc->proargtypes, proc->pronamespace);
 	}
 	else if (classId == CollationRelationId)
 	{
@@ -611,7 +611,7 @@ AlterObjectNamespace_internal(Relation rel, Oid objid, Oid nspOid)
 		Form_pg_proc proc = (Form_pg_proc) GETSTRUCT(tup);
 
 		IsThereFunctionInNamespace(NameStr(proc->proname), proc->pronargs,
-								   proc->proargtypes, nspOid);
+								   &proc->proargtypes, nspOid);
 	}
 	else if (classId == CollationRelationId)
 	{
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
@@ -1626,18 +1626,18 @@ DropCastById(Oid castOid)
  */
 void
 IsThereFunctionInNamespace(const char *proname, int pronargs,
-						   oidvector proargtypes, Oid nspOid)
+						   oidvector *proargtypes, Oid nspOid)
 {
 	/* check for duplicate name (more friendly than unique-index failure) */
 	if (SearchSysCacheExists3(PROCNAMEARGSNSP,
 							  CStringGetDatum(proname),
-							  PointerGetDatum(&proargtypes),
+							  PointerGetDatum(proargtypes),
 							  ObjectIdGetDatum(nspOid)))
 		ereport(ERROR,
 				(errcode(ERRCODE_DUPLICATE_FUNCTION),
 				 errmsg("function %s already exists in schema \"%s\"",
 						funcname_signature_string(proname, pronargs,
-												  NIL, proargtypes.values),
+												  NIL, proargtypes->values),
 						get_namespace_name(nspOid))));
 }
 
diff --git a/src/include/commands/defrem.h b/src/include/commands/defrem.h
@@ -50,7 +50,7 @@ extern Oid	AlterFunction(AlterFunctionStmt *stmt);
 extern Oid	CreateCast(CreateCastStmt *stmt);
 extern void DropCastById(Oid castOid);
 extern void IsThereFunctionInNamespace(const char *proname, int pronargs,
-						   oidvector proargtypes, Oid nspOid);
+						   oidvector *proargtypes, Oid nspOid);
 extern void ExecuteDoStmt(DoStmt *stmt);
 extern Oid	get_cast_oid(Oid sourcetypeid, Oid targettypeid, bool missing_ok);
 

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ AlterObjectRename_internal(Relation rel, Oid objectId, const char *new_name)`
`231`	`231`	`Form_pg_proc proc = (Form_pg_proc) GETSTRUCT(oldtup);`
`232`	`232`
`233`	`233`	`IsThereFunctionInNamespace(new_name, proc->pronargs,`
`234`		`- proc->proargtypes, proc->pronamespace);`
	`234`	`+ &proc->proargtypes, proc->pronamespace);`
`235`	`235`	`}`
`236`	`236`	`else if (classId == CollationRelationId)`
`237`	`237`	`{`
`@@ -611,7 +611,7 @@ AlterObjectNamespace_internal(Relation rel, Oid objid, Oid nspOid)`
`611`	`611`	`Form_pg_proc proc = (Form_pg_proc) GETSTRUCT(tup);`
`612`	`612`
`613`	`613`	`IsThereFunctionInNamespace(NameStr(proc->proname), proc->pronargs,`
`614`		`- proc->proargtypes, nspOid);`
	`614`	`+ &proc->proargtypes, nspOid);`
`615`	`615`	`}`
`616`	`616`	`else if (classId == CollationRelationId)`
`617`	`617`	`{`