Since SPI_modifytuple's natts argument is the number of attributes to be

tglsfdc · tglsfdc · commit 8723e37a26a3 · 2003-09-16T00:50:09.000Z
changed, it should allow a zero value (implying no changes to make).
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.103 2003/08/08 21:41:42 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.104 2003/09/16 00:50:09 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -409,7 +409,7 @@ SPI_modifytuple(Relation rel, HeapTuple tuple, int natts, int *attnum,
 	bool		isnull;
 	int			i;
 
-	if (rel == NULL || tuple == NULL || natts <= 0 || attnum == NULL || Values == NULL)
+	if (rel == NULL || tuple == NULL || natts < 0 || attnum == NULL || Values == NULL)
 	{
 		SPI_result = SPI_ERROR_ARGUMENT;
 		return NULL;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.103 2003/08/08 21:41:42 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.104 2003/09/16 00:50:09 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -409,7 +409,7 @@ SPI_modifytuple(Relation rel, HeapTuple tuple, int natts, int *attnum,`
`409`	`409`	`bool isnull;`
`410`	`410`	`int i;`
`411`	`411`
`412`		`- if (rel == NULL \|\| tuple == NULL \|\| natts <= 0 \|\| attnum == NULL \|\| Values == NULL)`
	`412`	`+ if (rel == NULL \|\| tuple == NULL \|\| natts < 0 \|\| attnum == NULL \|\| Values == NULL)`
`413`	`413`	`{`
`414`	`414`	`SPI_result = SPI_ERROR_ARGUMENT;`
`415`	`415`	`return NULL;`