Skip to content

Commit 890194f

Browse files
committed
Comment fixes related to logical decoding.
Andres Freund, per complaints by Peter Eisentraut.
1 parent c5608ea commit 890194f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

contrib/test_decoding/test_decoding.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
PG_MODULE_MAGIC;
3535

36+
/* These must be available to pg_dlsym() */
3637
extern void _PG_init(void);
3738
extern void _PG_output_plugin_init(OutputPluginCallbacks *cb);
3839

@@ -43,7 +44,6 @@ typedef struct
4344
bool include_timestamp;
4445
} TestDecodingData;
4546

46-
/* These must be available to pg_dlsym() */
4747
static void pg_decode_startup(LogicalDecodingContext *ctx, OutputPluginOptions *opt,
4848
bool is_init);
4949
static void pg_decode_shutdown(LogicalDecodingContext *ctx);

src/backend/replication/logical/logical.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,17 @@
1212
* together provide logical decoding, primarily by providing so
1313
* called LogicalDecodingContexts. The goal is to encapsulate most of the
1414
* internal complexity for consumers of logical decoding, so they can
15-
* create and consume a changestream with a low amount of code.
15+
* create and consume a changestream with a low amount of code. Builtin
16+
* consumers are the walsender and SQL SRF interface, but it's possible to
17+
* add further ones without changing core code, e.g. to consume changes in
18+
* a bgworker.
1619
*
1720
* The idea is that a consumer provides three callbacks, one to read WAL,
1821
* one to prepare a data write, and a final one for actually writing since
1922
* their implementation depends on the type of consumer. Check
20-
* logicalfunc.c for an example implementations of a fairly simple consumer
23+
* logicalfuncs.c for an example implementation of a fairly simple consumer
2124
* and a implementation of a WAL reading callback that's suitable for
22-
* simpler consumers.
25+
* simple consumers.
2326
*-------------------------------------------------------------------------
2427
*/
2528

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy